Closed
Bug 963092
Opened 11 years ago
Closed 11 years ago
Help subview items are styled incorrectly
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 29
People
(Reporter: u428464, Assigned: mikedeboer)
References
Details
(Whiteboard: [Australis:P3])
Attachments
(1 file)
|
1.13 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
With the new subview design the help items have an old styling on hover.
Blocks: australis-cust, 878546
Whiteboard: [Australis:P3]
|
||
Updated•11 years ago
|
No longer blocks: australis-cust
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mdeboer
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
Assignee | |
Comment 1•11 years ago
|
||
*sigh* forgot to re-add these after the refactor in bug 878546
Attachment #8364390 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8364390 [details] [diff] [review]
Patch v1: update help menu button styling
Review of attachment 8364390 [details] [diff] [review]:
-----------------------------------------------------------------
Yoink!
Attachment #8364390 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Thanks Jared!
remote: https://hg.mozilla.org/integration/fx-team/rev/533903493de2
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 29
There is still an issue. The font size is smaller than in other subviews.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Guillaume C. [:ge3k0s] from comment #5)
> There is still an issue. The font size is smaller than in other subviews.
True! I will post a patch here soon.
|
|
||
Comment 7•11 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #6)
> (In reply to Guillaume C. [:ge3k0s] from comment #5)
> > There is still an issue. The font size is smaller than in other subviews.
>
> True! I will post a patch here soon.
This can be handled in a new bug.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
QA Contact: cornel.ionce
|
||
Comment 8•11 years ago
|
||
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Verified as fixed on Firefox 29 beta 5 (build ID: 20140403132807).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•