Closed
Bug 963591
Opened 12 years ago
Closed 12 years ago
Help subview items have a smaller font size than others
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 29
People
(Reporter: mikedeboer, Assigned: mikedeboer)
References
Details
(Whiteboard: [Australis:P5])
Attachments
(1 file)
|
1.26 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #963092 +++
See summary.
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [Australis:P3] → [Australis:P5]
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8365113 [details] [diff] [review]
Patch v1: update font-size use in help subview toolbarbuttons
Review of attachment 8365113 [details] [diff] [review]:
-----------------------------------------------------------------
The history and feeds panel also don't have this class... don't they all need it?
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8365113 [details] [diff] [review]
Patch v1: update font-size use in help subview toolbarbuttons
(In reply to :Gijs Kruitbosch from comment #2)
> Comment on attachment 8365113 [details] [diff] [review]
> Patch v1: update font-size use in help subview toolbarbuttons
>
> Review of attachment 8365113 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> The history and feeds panel also don't have this class... don't they all
> need it?
Or really any of them except the bookmarks view. I'm confused. Can you explain? :-)
Attachment #8365113 -
Flags: review?(gijskruitbosch+bugs)
|
|
Assignee | |
Comment 4•12 years ago
|
||
This is because for all the other views, the `.PanelUI-subView` class is set by CustomizableUI.jsm here: http://dxr.mozilla.org/mozilla-central/source/browser/components/customizableui/src/CustomizableUI.jsm#1078
So this is dealing with the two exceptions: bookmarks and help view.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8365113 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Updated•12 years ago
|
Attachment #8365113 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Thanks!
remote: https://hg.mozilla.org/integration/fx-team/rev/77540823c057
Whiteboard: [Australis:P5] → [Australis:P5][fixed-in-fx-team]
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P5][fixed-in-fx-team] → [Australis:P5]
Target Milestone: --- → Firefox 29
|
||
Comment 7•11 years ago
|
||
Verified as fixed on Firefox 29 beta 5 (build ID: 20140403132807).
User Agents:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•