963109 - [Messages] Multi-recipient participants view should show back button instead of cross one

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[isabelrios]

master 01/23 build:
Gecko-163ee61
Gaia-00d8d05

STR
Create a new message 
Add to numbers or contacts into the To field
Add an attachment
Send the message
Once sent, open it and tap on the header
Once the recipient's details view is shown, go back tapping on '<' button

EXPECTED
To go back there should be the '<' icon

ACTUAL
Instead of the back button, it is shown the close 'x' one

With today's buri v1.3 build, the back icon is shown as expected:
Gecko-6840e8c
Gaia-744fb69

Comment 1

[Julien Wajsberg [:julienw]]

Hey Steve, can you have a look ?

Comment 2

[Steve Chung [:steveck]]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> Hey Steve, can you have a look ?

Sure, but we need more info from visual because another related message report view apply 'x' for the button.

Comment 3

[Julien Wajsberg [:julienw]]

Steve, the message report view needs "x", but the group view needs "<" :)

Comment 4

[José Vittone]

Attachment: Arrow + Transition on recipients

Yes, in this case should be an arrow, but also we should be adding a transition (like in the video) to make it more meaningful.

Comment 5

[Julien Wajsberg [:julienw]]

Yeah, we were waiting for bug 881469 for the transition. (not sure it will be _really_ easier though)

Comment 6

[Noemí Freire (:noemi)]

comms triage: not blocking v1.4, ask for approval when ready. In case it is not part of v1.4 it should be fixed in v1.5

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

Steve, is it something that can be fixed along with the 1.5 visual refresh? thanks

Comment 8

[Steve Chung [:steveck]]

Ya, we could definatly fix it in visual refresh.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

thanks Steven, then this is part of the 1.5 visual refresh

Comment 10

[Oleg Zasypkin [:azasypkin]]

As per comment 5, we're blocked by 881469 on transition part.

Comment 11

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Julien, 
this patch simply override the back button styling when in report view, but the ultimate goal should be separate report/multi-recipient view from threadui view. Do you think we could land this styling changes patch first, or we should separate views directly and put this issue to next sprint(or even next version)?

Comment 12

[Julien Wajsberg [:julienw]]

I think we should land this because this is part of the refresh.

Bug 961572 could be what you say. And also, I think we should add a class to the page body depending on the panel (that would also replace the "layout" dataset).

Comment 13

[Julien Wajsberg [:julienw]]

Comment on attachment 8429984 [details] [review]
Link to github

Added a suggestion on github.

Please ask a review from Oleg if you want a review before the end of the week :)

Comment 14

[Steve Chung [:steveck]]

Comment on attachment 8429984 [details] [review]
Link to github

Hey Oleg, I updated the patch based on some julien's suggestion. Could you please help with the review?

Comment 15

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8429984 [details] [review]
Link to github

(In reply to Steve Chung [:steveck] from comment #14)
> Comment on attachment 8429984 [details] [review]
> Link to github
> 
> Hey Oleg, I updated the patch based on some julien's suggestion. Could you
> please help with the review?

Sure, everything looks fine! r=me

Comment 16

[Steve Chung [:steveck]]

Thanks for the review and Travis is green now.
in master: af14823a08bd20efbd83157e0f952929a5ca7773

Comment 17

[Loli (:lolimartinezcr)]

Tested and working
Hamachi 
2.0
Gecko-c5087e3
Gaia-5dfe4ec