Closed
Bug 963166
Opened 10 years ago
Closed 10 years ago
getCurrentWindowHandles not matching WebDriver command getWindowHandles
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox28 fixed, firefox29 fixed)
RESOLVED
FIXED
mozilla29
People
(Reporter: ato, Assigned: ato)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
1.88 KB,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
It turns out getCurrentWindowHandles is Selenium 2.x compatible, but not WebDriver spec compatible. We will add getWindowHandles as the primary method and alias getCurrentWindowHandles and the Marionette specific getWindows to that.
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=a613287457be
Attachment #8365039 -
Flags: review?(dave.hunt)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8365039 [details] [diff] [review] 0001-Bug-963166-Add-getWindowHandles-end-point-for-WebDri.patch Review of attachment 8365039 [details] [diff] [review]: ----------------------------------------------------------------- This looks fine to me, but deflecting review to Mr. Burns, who knows this stuff better than me! :)
Attachment #8365039 -
Flags: review?(dave.hunt) → review?(dburns)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8365039 [details] [diff] [review] 0001-Bug-963166-Add-getWindowHandles-end-point-for-WebDri.patch Review of attachment 8365039 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/marionette/marionette-server.js @@ +2410,4 @@ > "refresh": MarionetteServerConnection.prototype.refresh, > "getCurrentWindowHandle": MarionetteServerConnection.prototype.getCurrentWindowHandle, > "getWindow": MarionetteServerConnection.prototype.getCurrentWindowHandle, // deprecated > + "getWindowHandles": MarionetteServerConnection.prototype.getWindowHandles, we should probably have a deprecated comment here like you have done for the other patches you have created
Attachment #8365039 -
Flags: review?(dburns) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
(In reply to David Burns :automatedtester from comment #3) > we should probably have a deprecated comment here like you have done for the > other patches you have created There is already a comment about getCurrentWindowHandles and getWindows being deprecated.
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/63761c123ba4
Keywords: checkin-needed
|
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/63761c123ba4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Whiteboard: checking-needed-aurora
|
|
||
Comment 7•10 years ago
|
||
This doesn't apply to Aurora. Please post a branch-specific patch or request checkin on whatever else this depends on.
Flags: needinfo?(ato)
Keywords: checkin-needed → branch-patch-needed
Whiteboard: checking-needed-aurora
|
|
Assignee | |
Comment 8•10 years ago
|
||
Added aurora branch specific patch in bug 963162. The patches should be applied in the following order: 1. Bug 941140 2. Bug 941144 3. Bug 963166 4. Revised patch in bug 963162
Flags: needinfo?(ato)
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•