963166 - getCurrentWindowHandles not matching WebDriver command getWindowHandles

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

It turns out getCurrentWindowHandles is Selenium 2.x compatible, but not WebDriver spec compatible.  We will add getWindowHandles as the primary method and alias getCurrentWindowHandles and the Marionette specific getWindows to that.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-963166-Add-getWindowHandles-end-point-for-WebDri.patch

try: https://tbpl.mozilla.org/?tree=Try&rev=a613287457be

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8365039 [details] [diff] [review]
0001-Bug-963166-Add-getWindowHandles-end-point-for-WebDri.patch

Review of attachment 8365039 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, but deflecting review to Mr. Burns, who knows this stuff better than me! :)

Comment 3

[David Burns :automatedtester]

Comment on attachment 8365039 [details] [diff] [review]
0001-Bug-963166-Add-getWindowHandles-end-point-for-WebDri.patch

Review of attachment 8365039 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-server.js
@@ +2410,4 @@
>    "refresh":  MarionetteServerConnection.prototype.refresh,
>    "getCurrentWindowHandle":  MarionetteServerConnection.prototype.getCurrentWindowHandle,
>    "getWindow":  MarionetteServerConnection.prototype.getCurrentWindowHandle,  // deprecated
> +  "getWindowHandles": MarionetteServerConnection.prototype.getWindowHandles,

we should probably have a deprecated comment here like you have done for the other patches you have created

Comment 4

[Andreas Tolfsen ❲:ato❳]

(In reply to David Burns :automatedtester from comment #3)
> we should probably have a deprecated comment here like you have done for the
> other patches you have created

There is already a comment about getCurrentWindowHandles and getWindows being
deprecated.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/63761c123ba4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/63761c123ba4

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This doesn't apply to Aurora. Please post a branch-specific patch or request checkin on whatever else this depends on.

Comment 8

[Andreas Tolfsen ❲:ato❳]

Added aurora branch specific patch in bug 963162.  The patches should be applied in the following order:

1. Bug 941140
2. Bug 941144
3. Bug 963166
4. Revised patch in bug 963162

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9a8f844bfa1d