Closed Bug 963166 Opened 7 years ago Closed 7 years ago

getCurrentWindowHandles not matching WebDriver command getWindowHandles

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(firefox28 fixed, firefox29 fixed)

RESOLVED FIXED
mozilla29
Tracking Status
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

It turns out getCurrentWindowHandles is Selenium 2.x compatible, but not WebDriver spec compatible.  We will add getWindowHandles as the primary method and alias getCurrentWindowHandles and the Marionette specific getWindows to that.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Blocks: 963299
Comment on attachment 8365039 [details] [diff] [review]
0001-Bug-963166-Add-getWindowHandles-end-point-for-WebDri.patch

Review of attachment 8365039 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, but deflecting review to Mr. Burns, who knows this stuff better than me! :)
Attachment #8365039 - Flags: review?(dave.hunt) → review?(dburns)
Comment on attachment 8365039 [details] [diff] [review]
0001-Bug-963166-Add-getWindowHandles-end-point-for-WebDri.patch

Review of attachment 8365039 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-server.js
@@ +2410,4 @@
>    "refresh":  MarionetteServerConnection.prototype.refresh,
>    "getCurrentWindowHandle":  MarionetteServerConnection.prototype.getCurrentWindowHandle,
>    "getWindow":  MarionetteServerConnection.prototype.getCurrentWindowHandle,  // deprecated
> +  "getWindowHandles": MarionetteServerConnection.prototype.getWindowHandles,

we should probably have a deprecated comment here like you have done for the other patches you have created
Attachment #8365039 - Flags: review?(dburns) → review+
(In reply to David Burns :automatedtester from comment #3)
> we should probably have a deprecated comment here like you have done for the
> other patches you have created

There is already a comment about getCurrentWindowHandles and getWindows being
deprecated.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/63761c123ba4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Keywords: checkin-needed
Whiteboard: checking-needed-aurora
This doesn't apply to Aurora. Please post a branch-specific patch or request checkin on whatever else this depends on.
Flags: needinfo?(ato)
Whiteboard: checking-needed-aurora
Added aurora branch specific patch in bug 963162.  The patches should be applied in the following order:

1. Bug 941140
2. Bug 941144
3. Bug 963166
4. Revised patch in bug 963162
Flags: needinfo?(ato)
You need to log in before you can comment on or make changes to this bug.