getCurrentWindowHandles not matching WebDriver command getWindowHandles

RESOLVED FIXED in Firefox 28

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

(Blocks 1 bug)

Trunk
mozilla29
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox28 fixed, firefox29 fixed)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
It turns out getCurrentWindowHandles is Selenium 2.x compatible, but not WebDriver spec compatible.  We will add getWindowHandles as the primary method and alias getCurrentWindowHandles and the Marionette specific getWindows to that.
(Assignee)

Updated

5 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Blocks: 963299
Comment on attachment 8365039 [details] [diff] [review]
0001-Bug-963166-Add-getWindowHandles-end-point-for-WebDri.patch

Review of attachment 8365039 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, but deflecting review to Mr. Burns, who knows this stuff better than me! :)
Attachment #8365039 - Flags: review?(dave.hunt) → review?(dburns)
Comment on attachment 8365039 [details] [diff] [review]
0001-Bug-963166-Add-getWindowHandles-end-point-for-WebDri.patch

Review of attachment 8365039 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-server.js
@@ +2410,4 @@
>    "refresh":  MarionetteServerConnection.prototype.refresh,
>    "getCurrentWindowHandle":  MarionetteServerConnection.prototype.getCurrentWindowHandle,
>    "getWindow":  MarionetteServerConnection.prototype.getCurrentWindowHandle,  // deprecated
> +  "getWindowHandles": MarionetteServerConnection.prototype.getWindowHandles,

we should probably have a deprecated comment here like you have done for the other patches you have created
Attachment #8365039 - Flags: review?(dburns) → review+
(Assignee)

Comment 4

5 years ago
(In reply to David Burns :automatedtester from comment #3)
> we should probably have a deprecated comment here like you have done for the
> other patches you have created

There is already a comment about getCurrentWindowHandles and getWindows being
deprecated.
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/63761c123ba4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: checking-needed-aurora
This doesn't apply to Aurora. Please post a branch-specific patch or request checkin on whatever else this depends on.
Flags: needinfo?(ato)
Whiteboard: checking-needed-aurora
(Assignee)

Comment 8

5 years ago
Added aurora branch specific patch in bug 963162.  The patches should be applied in the following order:

1. Bug 941140
2. Bug 941144
3. Bug 963166
4. Revised patch in bug 963162
Flags: needinfo?(ato)
You need to log in before you can comment on or make changes to this bug.