963174 - Reading list button will redirect you to history tab

Status: RESOLVED DUPLICATE of bug 961773

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Ioana Chiorean]

Build: 2014-01-23 Nightly Firefox 29
OS: Android 4.2.2
Device: Galaxy Nexus 

Steps:
1. Go to news.google.com and choose one article
2. Tab the reader mode button from awesomebar
3. After the article is loaded in reader mode add it to reading list (from reader mode toolbar)
4. Press the reading list button from toolbar 

Expected result:
- You should be directed to Reading list tab in about:home

Actual result:
- You are directed to History tab in about:home

Note:
- please see video https://www.youtube.com/watch?v=J2LIL7x9FU0

Comment 1

[Ioana Chiorean]

Last Good: 01/16
First bad: 01/17
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=324e2cba1029&tochange=9bcc52594322

I am working on an inbound regression as the push-log is pretty big

Comment 2

[:Margaret Leibovic]

I am fairly confident this would have been caused by bug 958175.

Comment 3

[Aaron Train [:aaronmt]]

(In reply to Ioana Chiorean from comment #1)
> I am working on an inbound regression as the push-log is pretty big

reminder that UI changes all land to fx-team these days

Comment 4

[Ioana Chiorean]

> reminder that UI changes all land to fx-team these days

well.. makes sense as the inbound was this: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f3b22524d1e5&tochange=c040b200b336 

I am on it on fx team now ...

Comment 5

[Ioana Chiorean]

On Fx-Team
Last Good: 1389809984 http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/fx-team-android/1389809984/
First bad: 1389815455 http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/fx-team-android/1389815455/

http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=1ec000cfc0a5&tochange=c518a5f33268

Comment 7

[Aaron Train [:aaronmt]]

Do we have an update here Lucas?

Comment 8

[Brian Nicholson (:bnicholson)]

We should also make sure that the reading list gets shown even if the home panel is hidden.

Since each panel is a fragment, maybe we can just show the reading list fragment on its own instead of the entire home pager?

Comment 9

[:Margaret Leibovic]

I wonder if this would be fixed by my patches in bug 961773. This sounds like it might be a dupe of that bug.

(In reply to Brian Nicholson (:bnicholson) from comment #8)
> We should also make sure that the reading list gets shown even if the home
> panel is hidden.
> 
> Since each panel is a fragment, maybe we can just show the reading list
> fragment on its own instead of the entire home pager?

This sounds more like bug 949178.

Comment 10

[Lucas Rocha (:lucasr)]

Margaret, isn't this bug fixed by your patches in bug 961773?

Comment 11

[:Margaret Leibovic]

(In reply to Lucas Rocha (:lucasr) from comment #10)
> Margaret, isn't this bug fixed by your patches in bug 961773?

Yeah, it should be. I'm marking this as a dupe.