963217 - Content rating shown in the wrong locale when the region is set to United States

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: content rating.png

steps to reproduce:
1. Make sure your region is set to US
2. Search for Phone
3. Notice the content rating for the app 'ThePhoneDB'


expected behavior:
Content rating says 'Teen'

observed behavior:
Content rating says 'Adoloscente'

Note that reloading the page usually fixes the problem

Comment 1

[Christopher Van Wiemeersch [:cvan]]

The API looks wrong:

    http://f.cl.ly/items/130M1m2v1k0l0s1d1I3f/Screen%20Shot%202014-01-23%20at%201.32.54%20PM.png

AFAICT, it's because the `description` and `rating` aren't being evaluated (`unicode(...)`) at the time of the request:

    https://github.com/mozilla/zamboni/blob/master/mkt/webapps/utils.py#L256-L258

Comment 2

[Kevin Ngo [:ngoke]]

I think they are being evaluated:

https://github.com/mozilla/zamboni/blob/master/mkt/webapps/utils.py#L250

calls

https://github.com/mozilla/zamboni/blob/master/mkt/webapps/utils.py#L250

which calls unicode.

Comment 3

[Kevin Ngo [:ngoke]]

Debugging notes:

- Refreshing an app over and over (e.g. https://marketplace.firefox.com/app/the-phone-database or https://marketplace.firefox.com/app/draw-nothing) from en-US, randomly yields either English or Spanish from the content ratings portion of the API response.

Is it because of the difference between being served from ES and from AppSerializer? I make sure responses from both go through a common dehydrating process that evaluates the Lazy objects.

Comment 4

[Mathieu Pillard [:mat]]

FYI I just landed bug 945820 so that might have some impact on this issue. Just something to keep in mind when you debug it.

Comment 5

[Kevin Ngo [:ngoke]]

Haven't been able to reproduce from -dev yet, maybe there's a fix amidst the patches from this week.

Comment 6

[Kevin Ngo [:ngoke]]

Not reproducing on stage. Closing to verify.

Comment 7

[Victor Carciu]

Verified as fixed : http://screencast.com/t/L6QIZ4vD

Comment 8

[krupa raj[:krupa]]

This still happens on prod. See https://www.dropbox.com/s/ogb1kmdekwtnfpr/Screenshot%202014-01-28%2012.31.33.png

https://marketplace.firefox.com/search?q=phone

Comment 9

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/1704

Comment 10

[Kevin Ngo [:ngoke]]

Have to devices side by side. One in Spanish, one in English.

STR:

1. Visit app listing page on the Spanish device.
2. Immediately view the page on the English second device.
3. Refresh the page on the Spanish device.

Expected:

All content ratings should be display respective to the device's language.

Actual:

Displayed in language of last visitor.

Comment 11

[Victor Carciu]

Kevin , this is what I see when using MP on my desktop with language set to English : http://screencast.com/t/bTNFawUSy

Comment 12

[Victor Carciu]

Also, the region is set to United States

Comment 13

[Kevin Ngo [:ngoke]]

Not yet pushed the patch, will unset the last milestone.

Comment 14

[krupa raj[:krupa]]

Using STR in comment 10, content rating shows up in the right locale.