963314 - Add pref for Fxa "settings" URL

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

We need a URL to indicate what URL should open when "Manage" is selected from the sync prefs pane.  I've broken this out from bug 960332 so it can land earlier.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0010-Bug-963314-Add-pref-for-Fxa-settings-URL.-r-ttaubert.patch

Adds a single pref pointing at the dev servers.

Comment 2

[Edwin Wong [:edwong]]

for those patch skimming challenged: 
pref("identity.fxaccounts.settings.uri", "https://accounts.dev.lcip.org/settings");

Comment 3

[Edwin Wong [:edwong]]

I thought we were going to use production URL endpoints for all prefs so that we don't need to change this in the future.  Then we're going to push PROD servers when required by clients.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

(In reply to Edwin Wong [:edwong] from comment #3)
> I thought we were going to use production URL endpoints for all prefs so
> that we don't need to change this in the future.  Then we're going to push
> PROD servers when required by clients.

Bug 960332 is to change all URLs to the production servers.  The patch there also includes an update for this pref, so the idea is this patch can land now and be consistent with what is already there, then bug  960332 can land whenever it is convenient (and comment 10 there says to not land this immediately)

Does that make sense?

Comment 5

[Chris Karlof [:ckarlof]]

We're going to push to prod tomorrow after a push to dev-prod clone and then push out bug 960332 to change everyone over.

Comment 6

[Chris Karlof [:ckarlof]]

Comment on attachment 8364708 [details] [diff] [review]
0010-Bug-963314-Add-pref-for-Fxa-settings-URL.-r-ttaubert.patch

Review of attachment 8364708 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1341,5 @@
>  
> +// The URL we take the user to when they opt to "manage" their Firefox Account.
> +// Note that this will always need to be in the same TLD as the
> +// "identity.fxaccounts.remote.uri" pref.
> +pref("identity.fxaccounts.settings.uri", "https://accounts.dev.lcip.org/settings");

Let's change this to https://accounts.firefox.com/settings now. It's not core functionality and it's essentially a "dead end" from the desktop perspective. I noticed a prod version of this URL wasn't in the desktop patch to update the prod urls, so it'll save us that work as well. r+ if we change this url to prod.

Comment 7

[Chris Karlof [:ckarlof]]

Change of plan. Prod urls for this will land in bug 960332.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/8daed13b402d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8daed13b402d

Comment 10

[Tracy Walker [:tracy]]

Verified with latest builds of Nightly and Aurora