Closed
Bug 960332
Opened 10 years ago
Closed 10 years ago
Update Firefox Account server URLs to use the production URLs
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
People
(Reporter: ckarlof, Assigned: markh)
References
Details
(Whiteboard: [qa+])
Attachments
(1 file, 3 obsolete files)
1.64 KB,
patch
|
markh
:
review+
|
Details | Diff | Splinter Review |
* firefox.accounts.remoteUrl -> https://accounts.firefox.com/?service=sync&context=fx_desktop * identity.fxaccounts.auth.uri -> https://api.accounts.firefox.com/v1 A another issue is that we should also make the pref names more consistent.
Reporter | ||
Comment 1•10 years ago
|
||
Issue to make the names more consistent: Bug 960334
Updated•10 years ago
|
Whiteboard: [qa+]
Reporter | ||
Comment 2•10 years ago
|
||
* firefox.accounts.remoteUrl -> https://accounts.firefox.com/?service=sync&context=fx_desktop_v1 * identity.fxaccounts.auth.uri -> https://api.accounts.firefox.com/v1 Updated to version the context.
Comment 3•10 years ago
|
||
fxa-content-server PR #296 [1] causes the content server front end to listen for messages from Firefox desktop if firefox.accounts.remoteUrl contains the `context=fx_desktop_v1` search paramater. [1] - https://github.com/mozilla/fxa-content-server/pull/296/files#diff-4a23ac1286faa3273c8cdc9b4bb5078dR80
Assignee | ||
Comment 4•10 years ago
|
||
Update the URLs
Assignee: nobody → mhammond
Attachment #8364066 -
Flags: review?(ckarlof)
Assignee | ||
Comment 5•10 years ago
|
||
This patch also adds a pref for the "settings" URL.
Attachment #8364066 -
Attachment is obsolete: true
Attachment #8364066 -
Flags: review?(ckarlof)
Attachment #8364069 -
Flags: review?(ckarlof)
Comment 6•10 years ago
|
||
I presume we should also be matching these on Android. We currently use: public static final String DEFAULT_IDP_ENDPOINT = "https://api-accounts-onepw.dev.lcip.org"; public static final String DEFAULT_TOKEN_SERVER_ENDPOINT = "http://auth.oldsync.dev.lcip.org"; What should those be?
Status: NEW → ASSIGNED
Summary: Update Firefox Account server URLs to use the production URLS → Update Firefox Account server URLs to use the production URLs
Target Milestone: mozilla29 → ---
Comment 7•10 years ago
|
||
We're doing this: https://github.com/mozilla-services/android-sync/commit/edc253007db00bc70336353038ffea7822df457d
Reporter | ||
Comment 8•10 years ago
|
||
Comment on attachment 8364069 [details] [diff] [review] 0012-Bug-960332-update-URLs-to-production-server.patch Review of attachment 8364069 [details] [diff] [review]: ----------------------------------------------------------------- Let's not land this immediately. We're not going to update prod FxA until 1/24 (gene on PTO), so it's prudent to remain on the dev box until then.
Attachment #8364069 -
Flags: review?(ckarlof) → review+
Reporter | ||
Comment 9•10 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #6) > I presume we should also be matching these on Android. > > We currently use: > > public static final String DEFAULT_IDP_ENDPOINT = > "https://api-accounts-onepw.dev.lcip.org"; > public static final String DEFAULT_TOKEN_SERVER_ENDPOINT = > "http://auth.oldsync.dev.lcip.org"; > > What should those be? Final API/IDP endpoint: https://api.accounts.firefox.com/v1 Final token server endpoint (Desktop change is not covered by this patch): https://token.services.mozilla.com (not currently live)
Reporter | ||
Comment 10•10 years ago
|
||
(In reply to Chris Karlof [:ckarlof] from comment #9) > Final token server endpoint (Desktop change is not covered by this patch): > https://token.services.mozilla.com (not currently live) Sorry, full endpoint is: https://token.services.mozilla.com/1.0/sync/1.5
Reporter | ||
Comment 11•10 years ago
|
||
See bug 963251 for token server URI changes.
Assignee | ||
Comment 12•10 years ago
|
||
Updated against bug 963314. Carrying r+ forward, but not landing.
Attachment #8364069 -
Attachment is obsolete: true
Attachment #8364709 -
Flags: review+
Assignee | ||
Comment 13•10 years ago
|
||
oops, screwed up the previous attachment.
Attachment #8364709 -
Attachment is obsolete: true
Attachment #8364799 -
Flags: review+
Reporter | ||
Comment 14•10 years ago
|
||
Since markh is already dev-ing with this patch applied, let's land at markh's convenience.
Reporter | ||
Comment 15•10 years ago
|
||
Need prod versions of the tos and pp urls in bug 959990
Assignee | ||
Comment 16•10 years ago
|
||
(In reply to Chris Karlof [:ckarlof] from comment #14) > Since markh is already dev-ing with this patch applied, let's land at > markh's convenience. Now's as good a time as any then! https://hg.mozilla.org/integration/fx-team/rev/464aa919d253
Comment 17•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/464aa919d253
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Mozilla Services → Firefox
Target Milestone: mozilla29 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•