963592 - [b2g] user agent overrides not working correctly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Recently I was trying to add a user agent override for a site in order to demonstrate to the developer that it would work on fxos.  It appears, though, that maybe the user agent overrides are not working correctly.

To see the problem:

1) Append the following in gecko's b2g/app/ua-updates.json.in:

    "whatsmyuseragent.com": "\\(Mobile#(Android; Mobile"

2) Flash gecko on the device.
3) Run make reset-gaia to force the immediate use of the ua-updates.json file.
4) Navigate to whatsmyuseragent.com in the device browser.

When I do this I see:

  Your user Agent String is:
  \(Mobile(Android; Mobile

It seems we're not actually applied a regex style substitution from this file like we did in v1.1.  Instead the contents of ua-updates.json entries simply replace the standard user agent.

Nom'ing for 1.3 since this seems like a serious problem.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Jim, do you have any idea what is going on here?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Looks like regex replacement is not being done for updates from ua-update.json. Should be a simple fix.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

By the way, I saw this on a v1.2 keon as well.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Perform replacements for updated UA overrides (v1)

This patch moves override replacement to its own function and calls the function for each override in the updated overrides list. The patch also adds a test for partial overrides.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/bcb7b4eed467

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bcb7b4eed467

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f607a137eb27