Closed
Bug 963612
Opened 10 years ago
Closed 10 years ago
Flags show up as "Review object" on review page
Categories
(Marketplace Graveyard :: Reviewer Tools, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-04-22
People
(Reporter: robhudson, Assigned: robhudson)
Details
(Whiteboard: [cosmetic])
Attachments
(1 file)
|
439.92 KB,
image/png
|
Details |
post-fix screenshot
Load https://marketplace-dev.allizom.org/reviewers/apps/review/twitter and find the "Flags" section. It lists them as "Review object, Review object, Review object". We should display something more meaningful. Open for comments on what it should list here as I'm not sure.
|
||
Updated•10 years ago
|
Whiteboard: [cosmetic]
|
||
Updated•10 years ago
|
Assignee: nobody → robhudson.mozbugs
Priority: -- → P2
|
||
Comment 1•10 years ago
|
||
fwiw, Kris fixed a very similar sounding bug for AMO here: https://bugzilla.mozilla.org/show_bug.cgi?id=863937 - might just be a copy&paste job?
|
Assignee | |
Comment 2•10 years ago
|
||
Thanks Andrew, that was helpful. I wasn't sure if "Flags" mean flagged reviews or those flags. This brings the flags from the list over to the detail page. https://github.com/mozilla/zamboni/commit/4d2f957
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-04-22
|
||
Comment 3•10 years ago
|
||
verified fixed at https://marketplace-dev.allizom.org/reviewers/apps/review/twitter and https://marketplace-dev.allizom.org/reviewers/apps/review/test-app-kjhcdk
Status: RESOLVED → VERIFIED
|
|
||
Comment 4•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•