Closed Bug 963817 Opened 6 years ago Closed 6 years ago

Wrap HomeStorage data insertion loop in a transaction

Categories

(Firefox for Android :: Data Providers, defect, P1)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 30

People

(Reporter: Margaret, Assigned: lucasr)

References

(Blocks 1 open bug)

Details

(Whiteboard: shovel-ready)

Attachments

(1 file, 1 obsolete file)

Follow-up to bug 942288.
Duplicate of this bug: 969059
To quote lucasr:

Right now we're execute an insert command per item in the passed list which is not very robust. We should:
- Batch insertions
- Enclose the save() call into a single transaction
Priority: -- → P1
Assignee: nobody → lucasr.at.mozilla
Attachment #8389293 - Attachment is obsolete: true
Attachment #8389295 - Flags: review?(margaret.leibovic)
FYI: it seems the resource://services-common/ alias is broken in Fennec. We'll have to fix bug 982191 before landing this patch.
Depends on: 982191
Comment on attachment 8389295 [details] [diff] [review]
Wrap HomeStorage data insertion loop in a transaction (r=margaret)

Review of attachment 8389295 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I love that we can add tests for these things.
Attachment #8389295 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/b07f0ec10d22
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Setting P1 hub bugs to block hub v1 EPIC bug (targeting fx30 release).

Filter on epic-hub-bugs.
Blocks: 1014025
You need to log in before you can comment on or make changes to this bug.