Closed
Bug 963817
Opened 12 years ago
Closed 12 years ago
Wrap HomeStorage data insertion loop in a transaction
Categories
(Firefox for Android Graveyard :: Data Providers, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: Margaret, Assigned: lucasr)
References
Details
(Whiteboard: shovel-ready)
Attachments
(1 file, 1 obsolete file)
|
3.15 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Follow-up to bug 942288.
|
Reporter | |
Comment 2•12 years ago
|
||
To quote lucasr:
Right now we're execute an insert command per item in the passed list which is not very robust. We should:
- Batch insertions
- Enclose the save() call into a single transaction
|
|
Reporter | |
Updated•12 years ago
|
Priority: -- → P1
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → lucasr.at.mozilla
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8389293 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8389295 -
Flags: review?(margaret.leibovic)
|
|
Assignee | |
Comment 5•12 years ago
|
||
FYI: it seems the resource://services-common/ alias is broken in Fennec. We'll have to fix bug 982191 before landing this patch.
Depends on: 982191
|
|
Reporter | |
Comment 6•12 years ago
|
||
Comment on attachment 8389295 [details] [diff] [review]
Wrap HomeStorage data insertion loop in a transaction (r=margaret)
Review of attachment 8389295 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, I love that we can add tests for these things.
Attachment #8389295 -
Flags: review?(margaret.leibovic) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
|
Reporter | |
Comment 9•12 years ago
|
||
Setting P1 hub bugs to block hub v1 EPIC bug (targeting fx30 release).
Filter on epic-hub-bugs.
Blocks: 1014025
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•