982191 - The resource://services-common/ alias is broken in Fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Which makes Sqlite.jsm fail to lazy load CommonUtils and cause all sorts of weirdness in HomeProvider tests.

Using resource://gre/modules/services-common works fine. Confirmed by trying to import using a remote debugger.

Comment 1

[Richard Newman [:rnewman]]

services/common/servicesComponents.manifest
2:resource services-common resource://gre/modules/services-common/

Comment 2

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Give this a shot?

Comment 3

[Nick Alexander :nalexander [he/him]]

This just isn't included in the Android build, see

http://mxr.mozilla.org/mozilla-central/search?string=servicesComponents

You just need to include it in mobile/android/installer/package-manifest.in, like the above examples.  This only registers the single alias above, so it looks fine.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8389313 [details] [diff] [review]
Proposed patch. v1

Review of attachment 8389313 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming it works :)

Comment 5

[Lucas Rocha (:lucasr)]

Yep, this fixes the issue, thanks.

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/b2b8ba047803

Does this need uplift, Lucas?

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Richard Newman [:rnewman] from comment #6)
> https://hg.mozilla.org/integration/fx-team/rev/b2b8ba047803
> 
> Does this need uplift, Lucas?

Nope.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b2b8ba047803