963898 - synthetic APK uninstall fails to remove app from registry

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: autouninstall.diff

Some change recently regressed app uninstallation with synthetic APKs, causing the WebappManager.autoUninstall to fail (silently), apparently because it tries to iterate over a list of apps it retrieves from the registry before the registry has a chance to populate the list.

I suspect the recent changes to DOMApplicationRegistry._readManifests in bug 959420, although I'd need to do more investigation to be sure.  In any case, the fix is relatively straightforward, and WebappManager.autoUninstall can actually be much simpler.

Here's a patch that fixes the bug by making WebappManager.autoUninstall access DOMApplicationRegistry.webapps directly instead of unnecessarily going through a message-passing API designed to cross processes.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8365485 [details] [diff] [review]
autouninstall.diff

mfinkle: perhaps you can take this review too?  wesj has a humongous review request from me on his plate.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8365485 [details] [diff] [review]
autouninstall.diff

At some point we should cleanup the dumps. I'm sure you want some, but maybe not all.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/efcbcdb857e2

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> At some point we should cleanup the dumps. I'm sure you want some, but maybe
> not all.

I want them all!  But only for debug builds.  Filed as bug 965875.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efcbcdb857e2