Closed Bug 963898 Opened 6 years ago Closed 6 years ago

synthetic APK uninstall fails to remove app from registry

Categories

(Firefox for Android :: Web Apps (PWAs), defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 29
Tracking Status
firefox30 --- verified

People

(Reporter: myk, Assigned: myk)

References

Details

(Keywords: regression)

Attachments

(1 file)

Some change recently regressed app uninstallation with synthetic APKs, causing the WebappManager.autoUninstall to fail (silently), apparently because it tries to iterate over a list of apps it retrieves from the registry before the registry has a chance to populate the list.

I suspect the recent changes to DOMApplicationRegistry._readManifests in bug 959420, although I'd need to do more investigation to be sure.  In any case, the fix is relatively straightforward, and WebappManager.autoUninstall can actually be much simpler.

Here's a patch that fixes the bug by making WebappManager.autoUninstall access DOMApplicationRegistry.webapps directly instead of unnecessarily going through a message-passing API designed to cross processes.
Attachment #8365485 - Flags: review?(wjohnston)
Comment on attachment 8365485 [details] [diff] [review]
autouninstall.diff

mfinkle: perhaps you can take this review too?  wesj has a humongous review request from me on his plate.
Attachment #8365485 - Flags: review?(wjohnston) → review?(mark.finkle)
Comment on attachment 8365485 [details] [diff] [review]
autouninstall.diff

At some point we should cleanup the dumps. I'm sure you want some, but maybe not all.
Attachment #8365485 - Flags: review?(mark.finkle) → review+
Duplicate of this bug: 965701
(In reply to Mark Finkle (:mfinkle) from comment #2)
> At some point we should cleanup the dumps. I'm sure you want some, but maybe
> not all.

I want them all!  But only for debug builds.  Filed as bug 965875.
https://hg.mozilla.org/mozilla-central/rev/efcbcdb857e2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.