Closed
Bug 964022
Opened 12 years ago
Closed 12 years ago
_load_collection_names uses self._collections_by_name when it should be using self._collections_by_id
Categories
(Cloud Services Graveyard :: Server: Sync, defect, P3)
Cloud Services Graveyard
Server: Sync
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rfkelly, Unassigned)
Details
(Whiteboard: [qa?])
Attachments
(1 file)
|
1.02 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
Easy fix, but this indicates a pretty serious shortcoming in our test coverage w.r.t. the STANDARD_COLLECTIONS functionality. I'll do a patch and some tests next week.
|
Reporter | |
Comment 1•12 years ago
|
||
Well that was easy, just enabling standard_collections=true in the test config showed up the bug. Since this is a one-line fix I'm going to take the liberty of committing it now so it's not blocking further Ops testing, but filed for review for formality.
Attachment #8365648 -
Flags: review?(telliott)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8365648 [details] [diff] [review]
sync1.5-standard-names-tests.diff
Review of attachment 8365648 [details] [diff] [review]:
-----------------------------------------------------------------
Oy, given how badly the standard collection logic has bitten us in the past, we should probably be doing table introspection tests to make sure that it's all doing the right thing. Something to think about at least.
Attachment #8365648 -
Flags: review?(telliott) → review+
|
|
||
Updated•12 years ago
|
Whiteboard: [qa?]
|
|
Reporter | |
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Priority: -- → P3
|
||
Updated•3 years ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•