Closed Bug 964035 Opened 8 years ago Closed 7 years ago

(gaia-rtl) Support RTL for Video App


(Firefox OS Graveyard :: Gaia::Video, defect)

Not set



ux-b2g 2.2


(Reporter: nefzaoui, Assigned: nefzaoui)



(Whiteboard: [rtl-meta])


(1 file)

46 bytes, text/x-github-pull-request
: review-
Details | Review
This bug is set for tracking and fixing everything related to Right-To-Left issues in Video App.
Blocks: gaia-rtl
Ahmed, I'd like to get this assigned. Let me know if you can take it or if I should find a Media developer. Thanks!
Flags: needinfo?(nefzaoui.ahmed)
Attached file Github pull-request
Taking :)

Added all the necessary RTL rules with two notes:

1) The video player slider & its controls are kept LTR (same approach for Music App)
2) Added 0.5rem padding (only in RTL) under the title of every property in "More Info" section because the font used in Arabic and Farsi (Droid Arabic Naskh) is making the text of each property and its value too close..
Assignee: nobody → nefzaoui.ahmed
Attachment #8469831 - Flags: review?(dflanagan)
Flags: needinfo?(nefzaoui.ahmed)
Comment on attachment 8469831 [details] [review]
Github pull-request


Would you take this review please? I don't know much about right-to-left localization myself. And if you don't either, feel free to ask Ahmed for details so you understand what the patch does and why. This is presumably a good learning opportunity for us.
Attachment #8469831 - Flags: review?(dflanagan) → review?(rnicoletti)

Would it be preferred to have the time sliders in the Music and Video apps go in the other direction for RTL locales?  Or is left-to-right a universal standard for this kind of UI element?
I marked this for 2.2 which means "2.2 or later". Right now, this should be an exploration. It should not *land* for 2.1 though we may want to work on it right now.

I say this because changing conceptions of time and/or order and hierarchy will require a lot of design thinking and potentially a lot of engineering support work. I think we need to review ALL of our animations in the context of possibly changing them, and ALL of the arrow keys (and not just arrow directionality, but the transitions and animations that accompany those UI elements), and talk about what that means across the entire OS - i.e. where we do it and do not and why (i.e. for Arabic but not for Hebrew, even though Hebrew also takes RTL UI elements). This will need heavy UX reviews and should not just be accepted as something we are definitely doing, but as more of an exploration right now.
ux-b2g: --- → 2.2
Comment on attachment 8469831 [details] [review]
Github pull-request

My knowledge of rtl support is limited. Ahmed, can you explain what your patch is doing and why? Thanks.

r- on the review because I agree with Stephany in comment 5 that there should be a full ux review of rtl support in our apps before making rtl changes. I think it's premature to review rtl changes before a ux review.
Attachment #8469831 - Flags: review?(rnicoletti) → review-
Resolving as WONTFIX as this will be replaced by a new 2.2 meta bug for RTL in Music, with child bugs attached.
Closed: 7 years ago
Resolution: --- → WONTFIX
Mass Edit: adding the [rtl-meta]
Whiteboard: [rtl-meta]
You need to log in before you can comment on or make changes to this bug.