964194 - B2G NFC: remove NFCTag.getDetailsNDEF()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This is mentioned by Jonas.

Are "DetailsNDEF"alreay ready when chrom sends out 'techDiscovered' system message? If so, then we should have those details contained in the 'techDiscovered' system message rather than exposing getDetailsNDEF().

Also Hsinyi mentioned maybe we could make those data as attributes in NFCTag.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think we should keep the getDetailsNDEF function if it triggers another radio roundtrip. But if we are getting the details in the radio communication we're already doing, then we might as well include them there.

Comment 2

[Garner Lee]

Things like "this tag type is read only, and 512 bytes in size" might be quite useful to NFC Tag application developers (it might possibly change if the tag type is changed).

There's some plans to add NDEFTag, MiFareTag, ISODepTag. So what we probably need <Tag Object Parent>.getDetails() in say, NFCTag instead if we keep it.

See: Bug 916428 (ISODep) for some ideas on that interface.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Since the result of this API are also available when tag is discovered,
So we will remove this method and will add another methods 'getMaxNDEFLength', 'isReadOnly', 'canBeMadeReadonly'.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8477277 [details] [diff] [review]
Patch

Hi Smaug
This interface getDetailsNDEF will retrieve the following information of the NFCTag from nfc daemon:
- Max NDEF length
- Is this tag readonly?
- Can this tag be made to readonly?

However getDetails is too verbose and we're going to split this to more attributes (or a getter method) to make it more easier to understand.
Like
maxNDEFLength, isReadOnly, ... etc

Also NFC Research Lab Hagenberg has sent a similar feedback to W3C NFC API. [1]
So we propose to remove this API for now.
We will file another bugs to discuss to add those attributes in our NFC API later because it needs some modification in our nfcd side, which is still under discussion now.

Can you help to review this for us?

Thanks

[1]: http://lists.w3.org/Archives/Public/public-nfc/2014Jan/0016.html

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8477277 [details] [diff] [review]
Patch

We have still ._nfcContentHelper.getDetailsNDEF and all the stuff.
Do we need all that?

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Smaug
Sorry for not being clear, like Bug 963541 we plan to remove this first from WebIDL, however we are still in-discussion that whether we should keep the oringinal impl or totally rewrite them. :P

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

add checkin-needed for b2g-inbound is close

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e74717ab1833

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e74717ab1833