Closed Bug 964272 Opened 6 years ago Closed 6 years ago

Expose last modified time on plugin tags

Categories

(Core :: Plug-ins, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

Attachments

(1 file, 2 obsolete files)

In nsPluginHost we need to know the lastModifiedTime for plugins anyway.
It shouldn't be too hard to keep and expose it on the plugin tags so that consumers like the PluginProvider [1] (and possibly changes from bug 928575 and bug 928574) don't need to hit the disk later.

[1] http://hg.mozilla.org/mozilla-central/annotate/611698b4a246/toolkit/mozapps/extensions/PluginProvider.jsm#l421
Status: NEW → ASSIGNED
https://tbpl.mozilla.org/?tree=Try&rev=07771c56563d

bsmedberg, does this look ok to you? I changed a little more to make it clear that nsPluginTag always starts off with a lastModifiedTime.
Once we have this, we could add also add this data point to the FHR plugin data.
Attachment #8377218 - Flags: review?(benjamin)
https://tbpl.mozilla.org/?tree=Try&rev=39c87239adc1

An OS X test fixup was required for [1] as we use nsILocalFileMac.bundleContentsLastModifiedTime there.

[1] /toolkit/mozapps/extensions/test/xpcshell/test_plugins.js
Attachment #8377218 - Attachment is obsolete: true
Attachment #8377218 - Flags: review?(benjamin)
Attachment #8377486 - Flags: review?(benjamin)
Missed catching the test exception for non-existing nsILocalFileMac on Windows.
Attachment #8377486 - Attachment is obsolete: true
Attachment #8377486 - Flags: review?(benjamin)
Attachment #8377553 - Flags: review?(benjamin)
Blocks: 973896
Attachment #8377553 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/4efc93b3c345
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 976861
You need to log in before you can comment on or make changes to this bug.