964272 - Expose last modified time on plugin tags

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement, P3)

Description

[Georg Fritzsche [:gfritzsche]]

In nsPluginHost we need to know the lastModifiedTime for plugins anyway.
It shouldn't be too hard to keep and expose it on the plugin tags so that consumers like the PluginProvider [1] (and possibly changes from bug 928575 and bug 928574) don't need to hit the disk later.

[1] http://hg.mozilla.org/mozilla-central/annotate/611698b4a246/toolkit/mozapps/extensions/PluginProvider.jsm#l421

Comment 1

[Georg Fritzsche [:gfritzsche]]

Attachment: Expose nsIPluginTag.lastModifiedTime

https://tbpl.mozilla.org/?tree=Try&rev=07771c56563d

bsmedberg, does this look ok to you? I changed a little more to make it clear that nsPluginTag always starts off with a lastModifiedTime.
Once we have this, we could add also add this data point to the FHR plugin data.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Attachment: Expose nsIPluginTag.lastModifiedTime, v2

https://tbpl.mozilla.org/?tree=Try&rev=39c87239adc1

An OS X test fixup was required for [1] as we use nsILocalFileMac.bundleContentsLastModifiedTime there.

[1] /toolkit/mozapps/extensions/test/xpcshell/test_plugins.js

Comment 3

[Georg Fritzsche [:gfritzsche]]

Attachment: Expose nsIPluginTag.lastModifiedTime, v3

Missed catching the test exception for non-existing nsILocalFileMac on Windows.

Comment 4

[Georg Fritzsche [:gfritzsche]]

https://tbpl.mozilla.org/?tree=Try&rev=c7e18c9c21c2

Comment 5

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4efc93b3c345

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4efc93b3c345