Closed
Bug 976861
Opened 10 years ago
Closed 10 years ago
nsPluginTag::GetLastModifiedTime should be declared with NS_IMETHODIMP
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: johns, Assigned: johns)
References
Details
Attachments
(1 file)
674 bytes,
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
Ran into this rebasing bug 558184 - the XPCOM calls in this file all use NS_IMETHODIMP, which, IIRC, affects the calling convention in windows. I'm not sure that it actually matters, but...
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8381792 -
Flags: review?(georg.fritzsche)
Comment 2•10 years ago
|
||
Comment on attachment 8381792 [details] [diff] [review] nsPluginTag::GetLastModifiedTime should use NS_IMETHODIMP Review of attachment 8381792 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for catching this.
Attachment #8381792 -
Flags: review?(georg.fritzsche) → review+
Updated•10 years ago
|
Summary: nsPluginTag::GetLastModifiedTime should be delcared with NS_IMETHODIMP → nsPluginTag::GetLastModifiedTime should be declared with NS_IMETHODIMP
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fbd6850f6a2
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8fbd6850f6a2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•