964623 - [TSF] nsTextStore::FlushPendingActions() shouldn't call OnLayouChange() and OnSelectionChange()

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, nsTextStore::FlushPendingActions() calls ITextStoreACPSink::OnLayoutChange(), ITextStoreACPSink::OnSelectionChange() and ITfContextOwnerServices::OnLayoutChange().

However, they shouldn't be called during document locked since the method cannot lock our document with nsTextStore::RequestLock().

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

I don't find any difference of behavior of Japanese TIPs. But I believe that this is right fix. (RequestLock() is always refused on current build if TIP tries to do something at calling OnLayouChange())

Comment 3

[Masatoshi Kimura [:emk]]

Is the document lock always held whenever nsTextStore::OnStartComposition, nsTextStore::OnUpdateComposition and nsTextStore::OnEndComposition are called?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> Is the document lock always held whenever nsTextStore::OnStartComposition,
> nsTextStore::OnUpdateComposition and nsTextStore::OnEndComposition are
> called?

I'm not sure since MSDN doesn't document it clearly. However, looks like that its counter part (TIP side) documents that it may return TS_E_NOLOCK.
http://msdn.microsoft.com/en-us/library/windows/desktop/ms538713%28v=vs.85%29.aspx
http://msdn.microsoft.com/en-us/library/windows/desktop/ms538684%28v=vs.85%29.aspx
http://msdn.microsoft.com/en-us/library/windows/desktop/ms538675%28v=vs.85%29.aspx

I created AutoPendingActionAndContentFlusher for safer handling, though.

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8369865 [details] [diff] [review]
Patch

Looks good to me. At least this patch will fix the violation of ITextStoreACPSink::OnSelectionChange() document.

http://msdn.microsoft.com/en-us/library/windows/desktop/ms538405%28v=vs.85%29.aspx
> When calling this method, the application must be able to grant a document lock.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41690ca5d8b9

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/41690ca5d8b9