964698 - Remove hard-coded collection name in test_everythingme_add_collection.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Now that bug 964215 is resolved, we should be able to pick a collection based on it's position and use it's label to verify the collection is added to the home screen.

Comment 1

[Karan Singh]

Hey,

I'll be working on this bug.

Comment 2

[Florin Strugariu [:Bebe]]

Hi Karan any updates on this Bug?
Can we help you with anything?

Comment 3

[Karan Singh]

Right now the test hangs when open_context_menu is called.

I believe this is because when I wrote this test a while back, I had to write an open_context_menu function for the homescreen since the homescreen wasn't using the expected menu (I think). I think the homescreen has been rewritten so it no longer uses the context_menu region of homescreen and uses the menu it's expected to use.

If that's true I have to make some changes to homescreens app.py and its regions, and rewrite the test slightly, but I've yet to look into it.

Comment 4

[Zac C (:zac)]

Ah yes, this may be the new rocketbar implementation.

Eventually we will migrate this test completely to use the rocketbar. Maybe it is worth holding off on this until that time is ready (maybe early next week).

I'm working on an app object now that you can work on top of.

Comment 5

[Zac C (:zac)]

Karan, I just got word from the devs that we should hold off on writing these new tests because they might temporarily disable the Rocketbar which would make this test case valid again!

Comment 6

[Karan Singh]

Alright cool, when it gets disabled did you still want me to remove the hard coded collection?

Comment 7

[Zac C (:zac)]

Yep. It's still valid, it's just a matter of whether we do it for rocketbar or non-rocketbar.

I'll mark it blocked for now.

Comment 8

[Zac C (:zac)]

Karan, this is unblocked now if you want to revisit it!

Comment 9

[Karan Singh]

Hey, I actually got a job where I signed a non-competition agreement so I'm not able to contribute to oss at the moment. Sorry!

Comment 10

[Zac C (:zac)]

:(( 
Congratulations though!

I'll put this one back out for community to take up.

Comment 11

[Robert Chira [:RobertC]]

Attachment: Pull request master

Comment 12

[Zac C (:zac)]

Comment on attachment 8420036 [details] [review]
Pull request master

r+, goes nicely thanks Robert :)

Comment 13

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/ff7423ab98d5c70adb702988a10bf23490d433a8