Closed Bug 964835 Opened 11 years ago Closed 11 years ago

Allow a machine name to be passed on the command line

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: davehunt, Assigned: davehunt)

References

Details

(Keywords: perf)

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/b2gperf/pull/33
42 bytes, text/x-github-pull-request
jgriffin
: review+
Details | Review
In the case of bug 964681 we are unable to get the MAC address, which is used as a unique identifier for the machine name. In this case we currently use 'unknown' as the machine name, which causes issues with the datazilla dashboard. We should allow a command line override for the machine name, so that in these cases we are still able to submit data.
Assignee: nobody → dave.hunt
Status: NEW → ASSIGNED
This patch will also prevent data from being submitted without a machine name, rather than submitting with 'unknown'.
Attachment #8366696 - Flags: review?(jgriffin)
Attachment #8366696 - Flags: review?(jgriffin) → review+
Landed in: https://github.com/mozilla/b2gperf/commit/910d48e6ebdbf1458431cd19291b198353f163df
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Depends on: 965426
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: