965001 - Add public IPs to EC2 instances

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

so we can route stuff over the public internet

Comment 1

[Chris AtLee [:catlee]]

let's focus on test machines first. if there's any single subnet we can switch over already, that would be awesome to test.

Comment 2

[Rail Aliiev [:rail]]

FTR, all bld-linux64-ec2 and try-linux64-ec2 instances use public IPs already.

Comment 3

[Rail Aliiev [:rail]]

ATM the following vms converted:

tst-linux64-ec2-0{01..19}
tst-linux64-ec2-3{01..19}

Comment 4

[Rail Aliiev [:rail]]

Phew, all on-demand instances have been converted and they associate public IPs now.

To make spot instances use network interfaces with public IPs I had to recreate the interfaces by calling run_instances with a network interface specification passed and terminate the instance right after that releasing the interface. I used this script https://hg.mozilla.org/build/braindump/rev/24130b841547 for this.

Comment 5

[Justin Wood (:Callek)]

(In reply to Rail Aliiev [:rail] from comment #4)
> Phew, all on-demand instances have been converted and they associate public
> IPs now.

I'm not so sure things are good, catlee pointed me here due to an issue I was seeing, where a loaner I'm creating with free_ip's got existing entries in inventory, twice in a row.... 

Upon closer inspection the entries exist in inventory but not in AWS (e.g. https://secure.pub.build.mozilla.org/builddata/reports/slave_health/slave.html?name=tst-linux32-ec2-133) which no longer has a home in AWS.

Can you please make sure that Inventory Matches what we *expect* AWS to be, and vice versa. I don't like the idea of having hosts in inventory and intended to be production when AWS doesn't have them. Such that our other code tries to create a loaner with an IP that other code expects to be associated elsewhere, and then chaos would ensue later.

(I just ran the free_ip script a few more times until I got one not associated with anything in inventory, to unblock me)

Comment 6

[Rail Aliiev [:rail]]

free_ip.py is just a helper to simplify the loaner process and it doesn't have inv-tool integration. I can see 2 ways to solve this:

* add inventory integration to the scripts and get rid of free_ip.py
* pre-create network interfaces with private IP addresses assigned so free_ip.py doesn't use them

In any case this is out of scope of this bug.