965081 - Always use https: protocol when adding Google maps event

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Jon Buckley [:jbuck]]

https://github.com/mozilla/popcorn.webmaker.org/blob/master/public/templates/assets/plugins/googlemap/popcorn.googlemap.js#L40 needs to be a https: URL instead of a protocol-less ("//") URL.

Comment 1

[Ashish]

Hi Jon, 

I would like to work on this issue. 

Thanks!

Comment 2

[Vick Makifina]

Hi Jon,

Having looked at (popcorn.googlemap.js) from your link above and also peeped in the (popcorn.webmaker) page source, I am more than comfortable to fix this bug. Please assign me to this bug.


Thanks.

Comment 3

[Jon Buckley [:jbuck]]

Hi Makifina, Ashish is currently working on this issue. I saw that you'd like to work on bug 965045, so I'll just assign that one to you

Comment 4

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/441

Comment 5

[Jon Buckley [:jbuck]]

Comment on attachment 8369466 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/441

:Ashish - r+ with nits. Could you:

1) Revert that change to the popcorn-js submodule
2) Rebase and squash your commits into a single commit?

Once you've done that, let me know and I'll merge it in. Thanks for doing this!

Comment 6

[Ashish]

Attachment: Always use https: protocol when adding Google maps event

Comment 7

[Jon Buckley [:jbuck]]

Comment on attachment 8370136 [details] [review]
Always use https: protocol when adding Google maps event

r+, thanks Ashish!

Merging now

Comment 8

[Jon Buckley [:jbuck]]

Merged into master as https://github.com/Subedy/popcorn.webmaker.org/commit/d8176f8441be536953d43dd8c7767d0c9bae1996