965096 - D3D9 textures should use image surfaces for ARGB

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Use image surfaces for ARGB content

Comment 1

[Nicolas Silva [:nical]]

Attachment: new textures version

Here is the equivalent patch for the non-deprecated textures. Although it doesn't render properly not sure what I missed yet.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Non-deprecated textures version

Ok, found my mistake, it works now.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8367061 [details] [diff] [review]
Use image surfaces for ARGB content

Review of attachment 8367061 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d9/TextureD3D9.cpp
@@ +863,5 @@
> +    }
> +  } else {
> +    D3DLOCKED_RECT rect;
> +    mD3D9Surface->LockRect(&rect, nullptr, 0);
> +    mSurface = new gfxImageSurface((uint8_t*)rect.pBits, ThebesIntSize(mSize), rect.Pitch, gfxImageFormatARGB32);

This needs a comment on why we can't use a gfxWindowsSurface for the reader. Here's my somewhat incomplete description:
// gfxWindowsSurface don't support transparency so we can't use the d3d9 windows surface optimization.
// Instead we have to use a gfxImageSurface and fallback for font drawing.

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8367478 [details] [diff] [review]
Non-deprecated textures version

Review of attachment 8367478 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d9/TextureD3D9.cpp
@@ +1340,5 @@
> +    mSurface = new gfxImageSurface((uint8_t*)rect.pBits, ThebesIntSize(mSize),
> +                                   rect.Pitch, gfxImageFormatARGB32);
> +    mLockRect = true;
> +  } else {
> +    mSurface = new gfxWindowsSurface(mD3D9Surface);

This should mirror the comment that bas will add.

Comment 5

[Nicolas Silva [:nical]]

landed with wrong bug number https://hg.mozilla.org/integration/mozilla-inbound/rev/224e15123ae0
backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/bcefaaf62761

and re-landed https://hg.mozilla.org/integration/mozilla-inbound/rev/b2670ddc0c97

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b2670ddc0c97