Closed Bug 965113 Opened 6 years ago Closed 6 years ago
figure out whether sync
Brand .fxa-singular .label/sync Brand .fxa-plural .label is OK from an l10n point of view
So far these strings are only used as titles, I think. But maybe they need to be properly plural-formed (https://developer.mozilla.org/en-US/docs/Localization_and_Plurals) so that they can vary depending on context? (bug 957426 and bug 965016 have some context about where these are used)
If they are just generic titles, I would drop those misleading "plural" and "singular" in the string ID and just call them section-header, dialog-title or similar. Strings should never be reused anyway in different contexts. The concept of singular/plural is basically wrong when it comes to l10n (see bug 476833 as a good example, or https://groups.google.com/forum/#!msg/mozilla.dev.l10n/sN8OfMIVk5A/vw82p1-BvuAJ). The correct behavior should be: expose the number of accounts in the string, and use a proper plural form. But we shouldn't need that for a title.
(In reply to Francesco Lodolo [:flod] from comment #1) > The correct behavior should be: expose the number of accounts in the string, > and use a proper plural form. But we shouldn't need that for a title. The idea is that the product name is called "Firefox Accounts" - eg, the signin page has "Firefox Accounts" as a heading. The singular form is used when talking about *your* Firefox Account - eg, in the Sync Options pane when you are signed in, a heading is titled "Firefox Account". IOW, it's never used in the context of a number. So maybe better names would include "-product-name-heading" and "-status-heading" or similar?
That's exactly what I meant ;-) Let's see if other people in CC have different thoughts.
Entities are now: <!ENTITY syncBrand.fxa-status.heading "Firefox Account"> <!ENTITY syncBrand.fxa-product.heading "Firefox Accounts">
Attachment #8367615 - Flags: review?(gavin.sharp)
Comment on attachment 8367615 [details] [diff] [review] 0009-Bug-965113-rename-fxa-plural-and-singular-entities-t.patch They are indeed only headers/titles, so some of my concerns about this are assuaged.
Attachment #8367615 - Flags: review?(gavin.sharp) → review+
My personal gut reaction is to not use the branded form when talking about a single account. This has impact on localized user experience, as "Firefox Account" won't be in your local language, while "My account" would be. We should acknowledge that for more than 50% of our users, "Firefox Account" is gonna feel foreign, and using a localized term might increase the bond between the product and the user.
Got rid of these strings in bug 965117. There is one remaining reference to "Firefox Account" in prefs. It's a title-cased noun, not a brand, necessarily, so any localization seems like it would work.
Depends on: 965117
I see two, not sure which one you're referring to http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/sync.dtd#51 http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/syncBrand.dtd#7 Does the first one need an update?
Assignee: mhammond → gavin.sharp
Attachment #8369294 - Flags: review?(mhammond)
Comment on attachment 8369294 [details] [diff] [review] patch Review of attachment 8369294 [details] [diff] [review]: ----------------------------------------------------------------- nice side-step of the problem :)
Attachment #8369294 - Flags: review?(mhammond) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.