965116 - figure out when to trigger the "must sign in again" UI

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

The UI in bug 964929 is currently never triggered. We need to show it when auth failures occur that can be resolved by signing in again.

Comment 1

[Chris Karlof [:ckarlof]]

Attachment: 0001-Add-basic-error-handling-to-browserid_identity-to-re.patch

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8368933 [details] [diff] [review]
0001-Add-basic-error-handling-to-browserid_identity-to-re.patch

Review of attachment 8368933 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/sync/modules/browserid_identity.js
@@ +403,4 @@
>      let tokenServerURI = Svc.Prefs.get("tokenServerURI");
>      let log = this._log;
>      let client = this._tokenServerClient;
> +    let fxaService = this._fxaService;

this was a bit of a mess before, but there is already a module global "fxAccounts" which can be used whereever this._fxaService is used - so I think we should clean this up now in this block.

@@ +426,5 @@
>      }
>  
> +    function getAssertion() {
> +      let audience = Services.io.newURI(tokenServerURI, null, null).prePath;
> +      return fxaService.getAssertion(audience)

please reindent this block

@@ +445,3 @@
>        .then(assertion => getToken(tokenServerURI, assertion))
>        .then(token => {
> +        // TODO: have it be only 80% of the duration, to avoid sync storage errors

this sounds serious enough to get a bug on file and referenced here, plus expand on the comment

@@ +453,5 @@
> +        // TODO: write tests to make sure that different auth error cases are handled here
> +        // properly: auth error getting assertion, auth error getting token (invalid generation
> +        // and client-state error)
> +        if (err instanceof AuthenticationError) {
> +          this._log.error("Authentication error in _fetchTokenForUser " + err.message);

add a ':' to the end of the literal

Comment 3

[Chris Karlof [:ckarlof]]

Attachment: 0001-Add-basic-error-handling-to-browserid_identity-to-re.patch

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/fx-team/rev/0646c8305465

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/0646c8305465