965165 - ChatZilla icon does not show up at Linux, falls back to browser icon

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Svetlana Tkachenko]

ChatZilla on Linux falls back to the default browser icon instead of showing its own. XPM icon files appear to be corrupt.

Comment 1

[Svetlana Tkachenko]

Attachment: chatzilla-window.xpm

This icon appears to be valid and belongs to xpi/resources/.

Comment 2

[Svetlana Tkachenko]

Attachment: chatzilla-window16.xpm

This icon also appears to be valid and belongs to xpi/resources/. (XPM icon 2 of 2.)

Comment 3

[Svetlana Tkachenko]

Attachment: Bug 965165.patch

Turns out there is no need to convert .ico to .xpm; the .xpm file format is human readable. "/* XPM */" has to be the first line.

> ftp://ftp.x.org/contrib/libraries/xpm-doc-A4.PS.gz
> The XPM format presents a C syntax, in order to provide the ability to include
XPM files in C.  It is in fact an array of strings composed of six different
sections as follows:
>
> /* XPM */
> static char * <variable name> [] = {
> <Values>
> <Colours>
> <Pixels>
> <Extensions>
> };

Comment 4

[Tony Mechelynck [:tonymec]]

Dupe of bug 664309? If not, it is still related.

Comment 5

[James Ross]

Comment on attachment 8367196 [details] [diff] [review]
Bug 965165.patch

Review of attachment 8367196 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the delays; this change looks good.

Comment 6

[James Ross]

http://hg.mozilla.org/chatzilla/rev/19b61cac1153