All users were logged out of Bugzilla on October 13th, 2018

Status

RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: gerv, Assigned: gerv)

Tracking

Details

Attachments

(1 attachment)

This bug tracks the MPL 2 upgrade for the project named in the subject line.
The repo is here: http://hg.mozilla.org/chatzilla/

Gerv
silver: should I just go ahead and attach a patch here?

Gerv

Comment 2

7 years ago
If that's the easiest approach, please do.

Comment 3

7 years ago
Just adding the rest of the team!

Comment 4

7 years ago
(In reply to Gervase Markham [:gerv] from comment #1)
> silver: should I just go ahead and attach a patch here?
> 
> Gerv

Pre-emptive review comment: the same stuff about the .pkg file as for Vnk applies here, too... :-)
Created attachment 601972 [details] [diff] [review]
Patch v.1

Here's a first patch. Let me know what you think :-)

Gerv
Attachment #601972 - Flags: review?(silver)

Comment 6

7 years ago
Comment on attachment 601972 [details] [diff] [review]
Patch v.1

Looks good; just two comments:
 - Some XML files have <!-- comments, others have # comments. E.g. locales/generic/chrome/contents.rdf vs locales/generic/install.rdf. I believe all the # comments in XML files are preprocessed so it works, just seems a little odd having the variation.
 - "...this file, You can obtain..." should be all lower-case?
Attachment #601972 - Flags: review?(silver) → review+
(In reply to James Ross from comment #6)
> Looks good; just two comments:
>  - Some XML files have <!-- comments, others have # comments. E.g.
> locales/generic/chrome/contents.rdf vs locales/generic/install.rdf. I
> believe all the # comments in XML files are preprocessed so it works, just
> seems a little odd having the variation.

This should simply be reflecting the existing comment chars. 

>  - "...this file, You can obtain..." should be all lower-case?

Nope; "You" is a defined term in the license.

Gerv
http://hg.mozilla.org/chatzilla/rev/6a579895d9ae

Gerv
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 965165
You need to log in before you can comment on or make changes to this bug.