716569 - MPL 2 upgrade: Chatzilla

Status: RESOLVED FIXED

(mozilla.org :: Licensing, task)

Description

[Gervase Markham [:gerv]]

This bug tracks the MPL 2 upgrade for the project named in the subject line.
The repo is here: http://hg.mozilla.org/chatzilla/

Gerv

Comment 1

[Gervase Markham [:gerv]]

silver: should I just go ahead and attach a patch here?

Gerv

Comment 2

[James Ross]

If that's the easiest approach, please do.

Comment 3

[James Ross]

Just adding the rest of the team!

Comment 4

[:Gijs (he/him)]

(In reply to Gervase Markham [:gerv] from comment #1)
> silver: should I just go ahead and attach a patch here?
> 
> Gerv

Pre-emptive review comment: the same stuff about the .pkg file as for Vnk applies here, too... :-)

Comment 5

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Here's a first patch. Let me know what you think :-)

Gerv

Comment 6

[James Ross]

Comment on attachment 601972 [details] [diff] [review]
Patch v.1

Looks good; just two comments:
 - Some XML files have <!-- comments, others have # comments. E.g. locales/generic/chrome/contents.rdf vs locales/generic/install.rdf. I believe all the # comments in XML files are preprocessed so it works, just seems a little odd having the variation.
 - "...this file, You can obtain..." should be all lower-case?

Comment 7

[Gervase Markham [:gerv]]

(In reply to James Ross from comment #6)
> Looks good; just two comments:
>  - Some XML files have <!-- comments, others have # comments. E.g.
> locales/generic/chrome/contents.rdf vs locales/generic/install.rdf. I
> believe all the # comments in XML files are preprocessed so it works, just
> seems a little odd having the variation.

This should simply be reflecting the existing comment chars. 

>  - "...this file, You can obtain..." should be all lower-case?

Nope; "You" is a defined term in the license.

Gerv

Comment 8

[Gervase Markham [:gerv]]

http://hg.mozilla.org/chatzilla/rev/6a579895d9ae

Gerv