965265 - Opening a new private window shows social provider buttons which don't do anything

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Banner (:standard8)]

STR:

1. Have a provider with a default button (e.g. Talkilla)
2. Open a private window

=> Social Provider buttons are displayed, but do nothing when you click on them.

Comment 1

[Florian Quèze [:florian]]

(In reply to Mark Banner (:standard8) from comment #0)

> => Social Provider buttons are displayed, but do nothing when you click on
> them.

Actually, clicking the button causes this error in the Browser Console:
NS_ERROR_NOT_IMPLEMENTED:  SharedFrame.jsm:137

Line 137 is:
      frame.QueryInterface(Ci.nsIFrameLoaderOwner).swapFrameLoaders(aTargetFrame);

This error makes sense; we are trying to swap a docshell from a non private window to a private window.

Comment 2

[Florian Quèze [:florian]]

Attachment: disable status buttons in private windows

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8367951 [details] [diff] [review]
disable status buttons in private windows

Add the same code and test for CreateSocialMarkWidget then r+ from me.

Comment 4

[Florian Quèze [:florian]]

Attachment: Patch v2

I added the same test for the Social Mark case, but not the code, as disabling is already handled by this code in browser-social.js:

310   get enabled() {
311     // Returns whether social is enabled *for this window*.
312     if (this._chromeless || PrivateBrowsingUtils.isWindowPrivate(window))
313       return false;
...
317   // called on tab/urlbar/location changes and after customization. Update
318   // anything that is tab specific.
319   updateState: function() {
320     if (!this.enabled)
321       return;
322     SocialMarks.update();

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/8c4807bfdd2a

Comment 6

[Carsten Book [:Tomcat]]

(In reply to Florian Quèze [:florian] [:flo] from comment #5)
> https://hg.mozilla.org/integration/fx-team/rev/8c4807bfdd2a

sorry had to backout this change for testfailures like https://tbpl.mozilla.org/php/getParsedLog.php?id=34209063&tree=Fx-Tea

5:04:59  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_perwindowPB.js | status button disabled on private window
05:04:59     INFO -  Stack trace:
05:04:59     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_perwindowPB.js :: tests.testPrivateBrowsing/</</< :: line 83
05:04:59     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/social/browser_social_perwindowPB.js :: postAndReceive/port.onmessage :: line 29
05:04:59     INFO -      JS frame :: resource://gre/modules/MessagePortBase.jsm :: fw_AbstractPort_onmessage :: line 57
05:04:59     INFO -      JS frame :: resource://gre/modules/FrameWorker.jsm :: _Worker.prototype.receiveMessage :: line 95
05:04:59     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 7

[Florian Quèze [:florian]]

I reduced the problem in comment 6 to the test testAddonManagerDoubleInstall from browser_social_activation.js. If I comment out that specific test, browser_social_perwindowPB.js passes.

Something interesting when looking at the browser window when browser_social_perwindowPB.js failed: widget.forWindow(pbwin).node.parentNode is null, and the social status button isn't visible in the toolbar.
When the test passes, the toolbar button is visible.

Comment 8

[Florian Quèze [:florian]]

After a green try build (https://tbpl.mozilla.org/?tree=Try&rev=4c0014fa9d86), relanding:

https://hg.mozilla.org/integration/fx-team/rev/f98c5c2d6bba

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f98c5c2d6bba

Comment 10

[Paul Silaghi, QA [:pauly]]

(In reply to Mark Banner (:standard8) from comment #0)
> STR:
> 
> 1. Have a provider with a default button (e.g. Talkilla)
> 2. Open a private window
> 
> => Social Provider buttons are displayed, but do nothing when you click on
> them.
The Talkilla button is still displayed (but no longer clickable) in private browsing, nightly 30.0a1 (2014-03-05), Win 7 x64.
Thoughts ?

Comment 11

[Florian Quèze [:florian]]

This is the expected behavior. The button is now disabled (not clickable) in private browsing. Before this fix, it was clickable and clicking it cause JavaScript errors (as mentioned on comment 1).

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed based on comment 11 on 30.0a1 (2014-03-05), win 7 x64.