965287 - IARC form never appears

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[:gerard-majax]

Attachment: Capture du 2014-01-29 17:15:13.png

Trying to fill the IARC form, this never appears.

STR:
 1. Go to your management page on marketplace/developpers
 2. Click on content rating, for example https://marketplace.firefox.com/developers/app/filatours/content_ratings/edit
 3. Click the button to create a certificate
 4. A new tab open, on https://www.globalratings.com/IARCProdRating/Submission.aspx

Expected:
 Website loads and I can fill the form

Actual:
 Part of the website loads, but content keeps being empty

I've been hitting this for several days now, and reproducing on multiple networks.

Comment 1

[:gerard-majax]

Opening up devtools on the marketplace tab, once I click on the IARC form creation button, I do see this in console:

> reflow : 0.43ms
> GET https://marketplace.firefox.com/api/v1/apps/app/filatours/content-ratings/ [HTTP/1.1 404 NOT FOUND 226ms]
> GET https://marketplace.firefox.com/api/v1/apps/app/filatours/content-ratings/ [HTTP/1.1 404 NOT FOUND 232ms]
> GET https://marketplace.firefox.com/api/v1/apps/app/filatours/content-ratings/ [HTTP/1.1 404 NOT FOUND 224ms]
> GET https://marketplace.firefox.com/api/v1/apps/app/filatours/content-ratings/ [HTTP/1.1 404 NOT FOUND 220ms]
> GET https://marketplace.firefox.com/api/v1/apps/app/filatours/content-ratings/ [HTTP/1.1 404 NOT FOUND 260ms]
> GET https://marketplace.firefox.com/api/v1/apps/app/filatours/content-ratings/ [HTTP/1.1 404 NOT FOUND 220ms]
> GET https://marketplace.firefox.com/api/v1/apps/app/filatours/content-ratings/ [HTTP/1.1 404 NOT FOUND 224ms]
> reflow : 0.34ms
> GET https://marketplace.firefox.com/api/v1/apps/app/filatours/content-ratings/ [HTTP/1.1 404 NOT FOUND 216ms]
> GET https://marketplace.firefox.com/api/v1/apps/app/filatours/content-ratings/ [HTTP/1.1 404 NOT FOUND 225ms]
> reflow : 0.86ms fonction updateCurrentBrowser, tabbrowser.xml ligne 1148

Comment 2

[krupa raj[:krupa]]

Do you mind checking if you have iARC open in a different tab?

Comment 3

[:gerard-majax]

I don't have IARC open.

Comment 4

[krupa raj[:krupa]]

I can reproduce this issue.

Comment 5

[krupa raj[:krupa]]

So, I have tried this a few times now.

Once, nothing happened.

The other times, the form loads but is blank. I see ReferenceError: hideshowAccordions is not defined which was bug 956381

Comment 6

[Kevin Ngo [:ngoke]]

Christine, could you take a look? Let us know if you need any information. Thanks!

Comment 7

[Christine McCarthy]

Kevin, the most likely situation here is that something is reacting poorly to a piece of data in the form submitted to the Submission.aspx page. Is it possible to get the data being used? We're not seeing failure when we test, but we're less likely to use "unusual" data. 

FWIW, the "ReferenceError: hideshowAccordions" will always appear when the form loads blank like this, because that javascript function is actually defined on the various content pages of the form, and all that is loading in this case is the master page.

Comment 8

[Kevin Ngo [:ngoke]]

Krupa, could you screenshot the hidden form parameters on the Get Certificate button?

Comment 9

[krupa raj[:krupa]]

<button class="create-iarc-rating button" data-redirect-url="/developers/app/test-app-aardvark89/content_ratings" data-api-url="/api/v1/apps/app/test-app-aardvark89/content-ratings/?since=2014-01-29+09%3A58%3A00" type="submit"></button>

Comment 10

[krupa raj[:krupa]]

more info @ https://pastebin.mozilla.org/4131018

Comment 11

[Kevin Ngo [:ngoke]]

Looks like we're passing in nothing for company name, which is a bug.

Comment 12

[krupa raj[:krupa]]

(In reply to Kevin Ngo [:ngoke] from comment #11)
> Looks like we're passing in nothing for company name, which is a bug.

This was working yesterday. How did this regress?

Comment 13

[Christine McCarthy]

Kevin, I was going to note the blank company name as well. Please let me know if that solves the issue.

Comment 14

[Kevin Ngo [:ngoke]]

I'm now reproducing even with a valid company name, so that might not be the issue. 

Here is what I pass in: https://pastebin.mozilla.org/4131644

Comment 15

[Kevin Ngo [:ngoke]]

Hey Christine, does anything possibly look off with those parameters? ^

I load the IARC page, but none of the form content.

Comment 16

[David Kassack]

Attachment: Capture.PNG

Kevin,

It seems that we received a submission...even if you never were able to see or complete the form.  Unless this is a diferent record.  Christine is in transit home.  She will take a look at this as soon as possible.  Does this occur every time the form opens?  It is tough for me to see exactly when this started occurring.  We have a lot of app submissions from @Mozilla.com over the past few hours.

Comment 17

[Kevin Ngo [:ngoke]]

It was okay a couple of hours ago, though I am now receiving blank content every time I try to open the IARC tool for several apps. Krupa is also running into this as well. Thanks for looking.

Comment 18

[David Kassack]

Attachment: New Ratings

We are still receiving some new rating submissions.  We'll get back to you ASAP.

Comment 19

[Christine McCarthy]

Kevin, can you confirm this is the DEMO IARC system? I will be available shortly before 7 EST to look into this.

Comment 20

[David Kassack]

Christine, It is the Production Version.  Simon has been able to duplicate the issue here.

Comment 21

[Christine McCarthy]

OK David, just to confirm: the issue is in production. It is sporadic, in that we are still receiving submissions, but frequent enough to replicatable. From the sounds of it, once someone has encountered the issue, they see it with great frequency? Did Simon find anything else of note when he replicated it? As I said before, I have no internet connection except my phone until shortly before 7, but I will get on this as quickly as possible.

Comment 22

[Kevin Ngo [:ngoke]]

Just an update, it is working for some of my apps now so it seems intermittent. I believe we have issues with the pingback, but that's most likely on our side.

Comment 23

[David Kassack]

Kevin,I see you successfully submitting Minimalist.  Are you doing anything different for these submissions?

Comment 24

[Kevin Ngo [:ngoke]]

I'm not doing anything different from before, though I can go through the tool now.

Comment 25

[Simon Rah]

Same thing here.  For the past 30min or so, I've been able to reproduce this error consistently while doing some trial and error with different parameters.  Thinking that there may be some caching going on, I closed my Chrome browser and restarted.  It suddenly started working with parameters values that weren't working before.  This happened just before Kevin noted that it started working for him.

At this point, I don't have an explanation for this, but it seems to work fine now.  We'll investigate further to see why this happened.

Comment 26

[Kevin Ngo [:ngoke]]

It's working for me, but Krupa has still currently been able to reproduce this issue (she got through briefly once) for her app "Test App (conjjy86t8)".

Comment 27

[Christine McCarthy]

Ok, I'm taking a look. I'm not seeing any changes we've made in production in the past couple weeks, files or database objects. I can't replicate the issue in Chrome, Internet Explorer, or Firefox. I see entries by Simon and Kevin in the database, both in PROD and DEMO, as well as some by Krupa. Has this, in general, seem to have righted itself? Can we readdress in the morning? Or are we still looking at an ongoing issue?

Comment 28

[krupa raj[:krupa]]

I can still reproduce the issue with the test app @ https://marketplace.firefox.com/developers/app/test-app-conjjvfy868/content_ratings/edit

However, I have noticed that it works for other apps and so, we are chasing an edge-case at this point. We can probably readdress this tomorrow. 

Thanks everyone for jumping on this asap.

Comment 29

[Dan S]

Hi - I'm getting this same issue. I'm trying to add a rating for my app: https://marketplace.firefox.com/app/lamp-light-torch/

I tried it when the first announcement came out (about two weeks ago) and again today and I get the blank(ish) page, header and footer but no form at all. I click the link from https://marketplace.firefox.com/developers/app/lamp-light-torch/content_ratings/edit which is the following form (I've anonymised my email address - but PLEASE NOTE my email address has a plus-sign in it, some systems get confused by that):

        <form id="iarc" method="post" action="https://www.globalratings.com/IARCProdRating/Submission.aspx" target="IARCForm">
          <input type="hidden" name="email" value="[e-mail]">
          <input type="hidden" name="company" value="Dan Stowell">
          <input type="hidden" name="appname" value="Lamp Light Torch">
          <input type="hidden" name="platform" value="Firefox">
          <input type="hidden" name="storefront" value="4">
          <input type="hidden" name="token" value="53711a6f2bd948d741e7a95f5f81303ac9ee66e8bd80a8f00944205ae9016ec97c2d92079236e12d734c9f03e5f24b419e06133b4cb81b8a3790457c45a44a9b">
          <input type="hidden" name="pingbackurl" value="https://marketplace.firefox.com/api/v1/apps/app/lamp-light-torch/content-ratings/pingback/">
          <p class="listing-footer">
            <button type="submit" class="create-iarc-rating button"
                    data-api-url="/api/v1/apps/app/lamp-light-torch/content-ratings/?since=2014-01-29+23%3A46%3A00"
                    data-redirect-url="/developers/app/lamp-light-torch/content_ratings">
              Create an IARC Ratings Certificate</button>
          </p>
        </form>

The browser console shows this error:

21:30:25.078 ReferenceError: hideshowAccordions is not defined Submission.aspx:6248

Comment 30

[Kevin Ngo [:ngoke]]

Thanks for the reproduce, Dan. We'll make sure this gets fixed soon.

Comment 31

[Christine McCarthy]

I am replicating the issue when I use an email address with a plus-sign in it. I am looking into why that might cause a problem for the system so we can hopefully get Dan's situation righted.

Comment 32

[:gerard-majax]

(In reply to Christine McCarthy from comment #31)
> I am replicating the issue when I use an email address with a plus-sign in
> it. I am looking into why that might cause a problem for the system so we
> can hopefully get Dan's situation righted.

That makes sense ; my email is also with a plus.

Comment 33

[Christine McCarthy]

Ok, we have resolved the issue with plus signs in email addresses. Our system was decoding the post data twice and turning the plus signs into spaces, which were then being rejected as malformed email addresses. We've corrected that issue, and users with plus signs in their email addresses should be able to get through now.

This issue was compounded by a second one. The messages which should have helped us identify the problems here ("Company name missing", "Invalid email address") are not displaying when they should. We are working on that issue now.

Thanks all!

Comment 34

[:gerard-majax]

I do confirm that the issue is now fixed, thanks for the fast fix !

Comment 35

[Christine McCarthy]

The issue with the missing error messages has also been resolved. Hopefully, this will help us address any future issues with greater speed and accuracy.

Comment 36

[Dan S]

Works for me too, thanks folks.