965474 - Initial Sync isn't triggered automatically

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Tracy Walker [:tracy]]

Using fx-team-<platform>/1390969090/ build:

0) install build and config new profile to use Fx Accounts
1) Create an account on device A (tested with Win 8.1)
2) Sign into same account on device B (tested with Mac 10.9)

tested results:

In both cases, the door hanger appears saying client is now syncing. But in reality no sync has occurred.

expected results:
after step 1) On client A, an initial upload of all sync data should occur. Then auto-syncs re-occur per various trigger rules.

after step 2) Client B's data should be successfully synced with client A's previously uploaded data. Then auto-syncs re-occur per various trigger rules.

Comment 1

[James Bonacci [:jbonacci]]

(assuming for now this is desktop-specific)

Comment 2

[Tracy Walker [:tracy]]

James,  I am pretty sure this is client side.  The client knows account was just setup, confirmed by the fact the door hanger notice appears.  It's just not triggering itself to do the initial sync.

Comment 3

[Tracy Walker [:tracy]]

You can jump start the auto-sync process by manually Sync Now client A, then Sync Now Client B.  I get succeful sync logs that are obeying timing triggers as well as bookmarking triggers.

Comment 4

[James Bonacci [:jbonacci]]

Given that, adding some more people...

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

The doorhanger won't lie anymore when bug 965544 lands. Mark is working on all the sync trigger points. Is there already a bug for that?

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(In reply to Tim Taubert [:ttaubert] from comment #5)
> The doorhanger won't lie anymore when bug 965544 lands. Mark is working on
> all the sync trigger points. Is there already a bug for that?

This is that bug.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

We've decided not to block Nightly enabling on this bug.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0007-Bug-965464-allow-for-an-initial-sync-on-new-user-sig.patch

Comment 9

[Chris Karlof [:ckarlof]]

Comment on attachment 8368372 [details] [diff] [review]
0007-Bug-965464-allow-for-an-initial-sync-on-new-user-sig.patch

Review of attachment 8368372 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/sync/modules/browserid_identity.js
@@ +125,5 @@
> +            Services.prefs.clearUserPref(PREF_SYNC_SHOW_CUSTOMIZATION);
> +          } else {
> +            // Log out if the user canceled the dialog.
> +            return fxAccounts.signOut();
> +          }

Customization logic should be refactored out to somewhere else at some point.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/fx-team/rev/b00d55e852bc

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b00d55e852bc