Closed Bug 965544 Opened 6 years ago Closed 6 years ago

Show "now syncing" doorhanger when sync actually starts, once per login

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 29

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [qa!])

Attachments

(1 file)

No description provided.
Whiteboard: [qa+]
The goal of this bug is to use the right notification to determine when to show the "now syncing" doorhanger. It will also remove some code that became obsolete with some rebasing done in a slight hurry yesterday.
Blocks: 905997
No longer blocks: 964922
Blocks: 965474
Comment on attachment 8367612 [details] [diff] [review]
0001-Bug-965544-Show-now-syncing-doorhanger-when-sync-act.patch

Review of attachment 8367612 [details] [diff] [review]:
-----------------------------------------------------------------

missing change to aboutaccounts.js which renames the showCustomizationDialog pref, but that's so trivial I'll r+ without seeing it.

::: services/sync/modules/browserid_identity.js
@@ +73,5 @@
>    },
>  
>    get needsCustomization() {
>      try {
> +      return Services.prefs.getBoolPref("services.sync.ui.showCustomizationDialog");

might as well use a constant for this value too
Attachment #8367612 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/mozilla-central/rev/cff14c669584
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Verified with latest builds of Nightly and Aurora
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.