965544 - Show "now syncing" doorhanger when sync actually starts, once per login

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-965544-Show-now-syncing-doorhanger-when-sync-act.patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

The goal of this bug is to use the right notification to determine when to show the "now syncing" doorhanger. It will also remove some code that became obsolete with some rebasing done in a slight hurry yesterday.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8367612 [details] [diff] [review]
0001-Bug-965544-Show-now-syncing-doorhanger-when-sync-act.patch

Review of attachment 8367612 [details] [diff] [review]:
-----------------------------------------------------------------

missing change to aboutaccounts.js which renames the showCustomizationDialog pref, but that's so trivial I'll r+ without seeing it.

::: services/sync/modules/browserid_identity.js
@@ +73,5 @@
>    },
>  
>    get needsCustomization() {
>      try {
> +      return Services.prefs.getBoolPref("services.sync.ui.showCustomizationDialog");

might as well use a constant for this value too

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/cff14c669584

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cff14c669584

Comment 6

[Tracy Walker [:tracy]]

Verified with latest builds of Nightly and Aurora