965620 - Need an interface to abstract which radio interface is being used to bring up a DataCall

Status: RESOLVED DUPLICATE of bug 904514

(Firefox OS Graveyard :: RIL, defect)

Description

[Bhavna Sharma]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.76 Safari/537.36

Steps to reproduce:

setup a data by type i.e. nsIRadioInterface->setupdatacallbytype


Actual results:

The interface to setup the data call is very much tied to a radio interface.
Why should the upper layers be aware oh which sim (i.e. which radio interface) is being used to bring up a DataCall.

Requires a number of steps to be able to bring up the dataCall

// Find the DD sim first using ‘ril.data.defaultServiceId’
// Query on nsISettingsService

// Query for ril service
    nsCOMPtr<nsIRadioInterfaceLayer> ril;
    ril = do_GetService("@mozilla.org/ril;1");

// Query for radio interface
    nsCOMPtr<nsIRadioInterface> radioInterface;
    nsRes = ril->GetRadioInterface(mDedicatedDataSIM, getter_AddRefs(radioInterface));

// RegisterDatacallcallback
nsRes = mRadioInterface->RegisterDataCallCallback(this);

// bring up data call
mRadioInterface->SetupDataCallByType(NS_LITERAL_STRING("supl"));

In multisim scenario there should be a DataConnection manager which should abstract the radio interface details from the upper layers.


Expected results:

There should have been a DataConnectionManager that can abstract the radiointerface details from upper layers.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Bhavna Sharma from comment #0)
> User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML,
> like Gecko) Chrome/32.0.1700.76 Safari/537.36
> 
> Steps to reproduce:
> 
> setup a data by type i.e. nsIRadioInterface->setupdatacallbytype
> 
> 
> Actual results:
> 
> The interface to setup the data call is very much tied to a radio interface.
> Why should the upper layers be aware oh which sim (i.e. which radio
> interface) is being used to bring up a DataCall.
> 
> Requires a number of steps to be able to bring up the dataCall
> 
> // Find the DD sim first using ‘ril.data.defaultServiceId’
> // Query on nsISettingsService
> 
> // Query for ril service
>     nsCOMPtr<nsIRadioInterfaceLayer> ril;
>     ril = do_GetService("@mozilla.org/ril;1");
> 
> // Query for radio interface
>     nsCOMPtr<nsIRadioInterface> radioInterface;
>     nsRes = ril->GetRadioInterface(mDedicatedDataSIM,
> getter_AddRefs(radioInterface));
> 
> // RegisterDatacallcallback
> nsRes = mRadioInterface->RegisterDataCallCallback(this);
> 
> // bring up data call
> mRadioInterface->SetupDataCallByType(NS_LITERAL_STRING("supl"));
> 
> In multisim scenario there should be a DataConnection manager which should
> abstract the radio interface details from the upper layers.
> 
> 
> Expected results:
> 
> There should have been a DataConnectionManager that can abstract the
> radiointerface details from upper layers.

We've been planning this, see the meta bug 904514.

Comment 2

[Ken Chang[:kenkai]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #1)
> We've been planning this, see the meta bug 904514.
It's a big change. we don't need to be rush to finish it in 1.4.

Comment 3

[Preeti Raghunath(:Preeti)]

Hi Ken

This blocks QC CS in release 1.4. We need to fix it in 1.4 unless we believe its a heavy load to carry.

Comment 4

[Julien Wajsberg [:julienw]]

Why is it a blocker exactly?

Comment 5

[Bhavna Sharma]

hi Julien,

As of now we only support DSDS configurations, hence we can go without fixing this issue.
Once we have DSDA support it will become difficult for the clients to know which radio interface to use to bring up the DataCall.

I leave it you to decide on its priority, for v1.4 it is not a blocker.

- Bhavna

Comment 6

[Ken Chang[:kenkai]]

According to comment 5, we got the answer.

Comment 7

[Julien Wajsberg [:julienw]]

Bhavna: thanks for your detailed answer, be sure to bring this up again (and early enough ;) ) once we start working on DSDA !

Comment 8

[Ken Chang[:kenkai]]

Put this bug into backlog.

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

bug 904514 covers this. Close it as duplicate.