965652 - Indicate the availability of a context menu with a cursor change.

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Erik Rose [:erik][:erikrose]]

There's a nice "there's a contextual menu here" cursor in CSS now. Let's use it wherever we offer context menus as an additional clue.

Comment 1

[Vedad Hadžić [:vedad][:vedadux]]

Attachment: Changing the cursor fo <a> inside <code>

I realised that the long context menus were all for code marked as <a> tag. I changed the cursor property for <a> elements inside a <code> element in dxr.css. Is this enough?

Comment 2

[Erik Rose [:erik][:erikrose]]

Comment on attachment 8467758 [details] [diff] [review]
Changing the cursor fo <a> inside <code>

Review of attachment 8467758 [details] [diff] [review]:
-----------------------------------------------------------------

I think that might overreach a bit. For example, there are <code> tags used in the Filters menu, and I could see there someday being an anchor in there. We should limit it further. You can take inspiration from the JS that makes the context menus: the CSS should be of similar scope.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/567ccb97d6aae937ee6dccc26f9186fa2ace0d7b
Fixing bugs: 1053423, 1052524 and 965652
For 965652:
	dxr.css :
	Added a rule for .code code a in order to show availability of context-menus but limited in order not to overwrite a rule somewhere else.
For 1052524:
	file.html :
	Added the .icon class to all anchors in the panel
	dxr.css :
	Removed padding form (.panel section a) since it blocks the added .icon class
For 1053423:
	context_menu.html :
	Added the .icon class to all anchors in the list in order to have a pseudoparent class and eliminate a lot of repeating in icons.css
	dxr.css :
	Removed padding from (.context-menu a) since it blocks the added .icon class
	icons.css :
	Made a lot of changes and removed the repeating rules for background since they are no longer needed because of the .icon class
Other:
Fixed .build in icons.css that I missed it the last time.
Added comments in icons.css in order to show rearanged sections.
Added a lot missing icon classes which are referenced in .panel and .context-menu .
Since the .panel icons that are always shown are probably going to be redone they are commented out untill the time has come.
That's about it. Will mention if I find something else.

https://github.com/mozilla/dxr/commit/e0094f3f78fa4361b84905489dff7328cb55ca1f
Indicate existence of context menus with cursor change: fix bug 965652. Fix repeated Diff icon: fix bug 1052524. Polish look of context menus: fix bug 1053423.

Comment 4

[[github robot]]

Commits pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/567ccb97d6aae937ee6dccc26f9186fa2ace0d7b
Fixing bugs: 1053423, 1052524 and 965652

https://github.com/mozilla/dxr/commit/e0094f3f78fa4361b84905489dff7328cb55ca1f
Indicate existence of context menus with cursor change: fix bug 965652. Fix repeated Diff icon: fix bug 1052524. Polish look of context menus: fix bug 1053423.