965659 - Intra-file nav links missing

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect, P2)

Description

[Erik Rose [:erik][:erikrose]]

On prod, analyzable files have links to structural elements in the Navigation pane. On stage, they're missing; all we have is the version-control links.

Compare:
http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/Database.cpp
http://dxr.allizom.org/mozilla-central/source/toolkit/components/places/Database.cpp

Comment 1

[Schalk Neethling [:espressive]]

Do we have a test case for this?

Comment 2

[Erik Rose [:erik][:erikrose]]

No, not beyond building moz-central in its entirety. Why don't you have a quick look through the JS logic paths that deal with the nav pane and see if you see any obvious bugs? If not, move on to squashing some of the other presentation bugs, like the scrolling Filters menu, bug 965665, and bug 968017.

Changing this to not block UI rollout. The nav pane isn't used as much as I thought, and the one in prod isn't flawless either.

Comment 4

[Erik Rose [:erik][:erikrose]]

I'm going to have a look at this. I have hope it's easy.

Comment 5

[Erik Rose [:erik][:erikrose]]

Simple tests like test_types.py work. It makes me suspect types aren't getting into the types table. Ick. I'll have a look at the DB in production to see.

Comment 6

[Erik Rose [:erik][:erikrose]]

Fixed accidentally in https://github.com/mozilla/dxr/commit/5cbac3e87cf5af20f268b384eb3c8f3158ef8554 and put entirely right in https://github.com/mozilla/dxr/commit/bd168d05544423c1477e1a44babf54c2dbd2718f. It happened when there were multiple <section>s, which never should have happened in the first place, and the JS responsible for showing the panel would show only the first one. That JS is gone now, with the added bonus that the nav panel pops up promptly, without waiting for the entire page to load.