965689 - users should be able to tag their own comments, regardless of group membership

Status: NEW

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[:glob ✱]

users should be able to tag their own comments, regardless of group membership

Comment 1

[Frédéric Buclin]

I disagree. It's too easy to mess comment tags this way. A spammer or someone without the required knowledge could mark his comments as important or something like that despite they are not, defeating the goal to hide some comments with the spam tag or to categorize comments. This also means a spammer would be able to remove the spam tag. Personally, this is WONTFIX.

Comment 2

[:glob ✱]

(In reply to Frédéric Buclin from comment #1)
> I disagree. It's too easy to mess comment tags this way. A spammer or
> someone without the required knowledge could mark his comments as important
> or something like that despite they are not defeating the goal to hide some
> comments with the spam tag or to categorize comments. 

this is no different from how we treat bugs. eg. a bug's reporter can change a bug's priority.

> This also means a spammer would be able to remove the spam tag.

true, but if you aren't disabling the accounts of spammers then you're in for trouble regardless (they can just make new comments).

Comment 3

[Frédéric Buclin]

(In reply to Byron Jones ‹:glob› from comment #2)
> this is no different from how we treat bugs. eg. a bug's reporter can change
> a bug's priority.

Right, and I have always been against this.


> true, but if you aren't disabling the accounts of spammers then you're in
> for trouble regardless (they can just make new comments).

You intentionally omitted the "or someone without the required knowledge" part of my comment? You certainly wouldn't want to disable accounts of users who misuse comment tags.


That being said, you didn't give any rationale to allow commenters to edit tags. "should be able to" isn't a reason.

Comment 4

[:glob ✱]

(In reply to Frédéric Buclin from comment #3)
> That being said, you didn't give any rationale to allow commenters to edit
> tags. "should be able to" isn't a reason.

the rational i gave is for parity with the permissions model on bug fields.  that you're against the current functionality doesn't equate to me not providing rationale.

Comment 5

[Frédéric Buclin]

(In reply to Byron Jones ‹:glob› from comment #4)
> the rational i gave is for parity with the permissions model on bug fields. 

Several fields aren't editable by the bug reporter when he hasn't editbugs privs: assignee, QA contact, target milestone, group restrictions (once the bug is filed), flags with a grant or request group, and the bug status has limitations. So the parity argument doesn't work here. You and I can point the other one to fields which serve their purposes.


> that you're against the current functionality doesn't equate to me not
> providing rationale.

Sure, but then why not allow everybody delete or edit their own comments in bug 540, then, for parity?

Comment 7

[Mr. Beedell, Roke Julian Lockhart]

https://bugzilla.mozilla.org/show_bug.cgi?id=965689#c1

[e-mail], you can prevent spammers leveraging this by permitting users to mark their comments as off-topic (and other non-destructive markings) rather than important. GitHub does this - it allows users to hide their comments, but not increase the visibility of them.