965732 - [DSDS][FTE] Incorrect Order in screens in FTE when user presses "Back" button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Loli (:lolimartinezcr)]

Tested in master:
Build ID: 20140130101312
Platform version: 29.0a1
Git comint: f856ac26

Steps:
In FTE
Tap "Next" button
Tap "Skip" and not insert PIN in SIM1 card
Tap "Skip" and not insert PIN in SIM2 card
Tap "Next" in "SIM manager" screen
Tap "Back"

Actual result:
Enter PIN code screen

Expected result:
"SIM manager" screen

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

This was actually done on purpose based on a code review of the initial FTE DSDS work: https://bugzilla.mozilla.org/show_bug.cgi?id=926347#c32. The SIM unlock screens are overlays on top of the SIM Manager step, so when going back to SIM Manager step we check if either of the SIM cards are still locked and if so pop up the unlock overlays again.

Loli, is there a moz-traps test case for this? I didn't see one here: https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2306 but perhaps I missed it. If there is, I think we need to update this to reflect the flow.

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Just to make sure, let's verify from UX. Jacqueline, I think you were heading up the DSDS work at one point. Is version 0.8 the latest spec in regards to the DSDS FTE stuff (https://bug917705.bugzilla.mozilla.org/attachment.cgi?id=8334341)? If so, it doesn't specify the behavior directly of what happens when a user skips the unlock screens and then clicks back from the next step of the FTE. However, based on bug 926347 I think you were ok on the flow we had in place. Can you weigh in on this bug here (ie, is it ok to re-show the SIM unlock screens when going back from the FTE step after the SIM Manager)?

Comment 3

[Loli (:lolimartinezcr)]

(In reply to Michael Henretty [:mhenretty] from comment #1)
> This was actually done on purpose based on a code review of the initial FTE
> DSDS work: https://bugzilla.mozilla.org/show_bug.cgi?id=926347#c32. The SIM
> unlock screens are overlays on top of the SIM Manager step, so when going
> back to SIM Manager step we check if either of the SIM cards are still
> locked and if so pop up the unlock overlays again.
> 
> Loli, is there a moz-traps test case for this? I didn't see one here:
> https://moztrap.mozilla.org/manage/cases/
> ?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-
> tag=2306 but perhaps I missed it. If there is, I think we need to update
> this to reflect the flow.

I have readed tests cases and this case isn't in moztraps

Comment 4

[Noemí Freire (:noemi)]

(In reply to Michael Henretty [:mhenretty] from comment #2)
> Just to make sure, let's verify from UX. Jacqueline, I think you were
> heading up the DSDS work at one point. Is version 0.8 the latest spec in
> regards to the DSDS FTE stuff
> (https://bug917705.bugzilla.mozilla.org/attachment.cgi?id=8334341)? If so,
> it doesn't specify the behavior directly of what happens when a user skips
> the unlock screens and then clicks back from the next step of the FTE.
> However, based on bug 926347 I think you were ok on the flow we had in
> place. Can you weigh in on this bug here (ie, is it ok to re-show the SIM
> unlock screens when going back from the FTE step after the SIM Manager)?

Hi,

Following the latest DSDS spec v0.8 pag15(https://bug917705.bugzilla.mozilla.org/attachment.cgi?id=8334341), the expected behavior after skipping "unlock SIM1/SIM2" screens and select "back button" within SIM manager would be to go to "Language selection" screen (sorry for the mistake in https://bugzilla.mozilla.org/show_bug.cgi?id=965732#c0). Adding also Carrie in this loop to shed some light here. Thanks!

Comment 5

[Carrie Wang [New account: [e-mail]]]

Hi, 

The expected flow will be, 
If users tap "back" on the SIM manager page, it will go back to the language selection page.
If users tap "back" on the page which is the next step of SIM manager, it will go back to the SIM manager.

Thanks!

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Carrie Wang [:carrie] from comment #5)
> The expected flow will be, 
> If users tap "back" on the SIM manager page, it will go back to the language
> selection page.

Cool, this is how it works now.

> If users tap "back" on the page which is the next step of SIM manager, it
> will go back to the SIM manager.

Ok given these two criteria, we would have the following flow:

1.) user skips the sim pin unlock screens
2.) user clicks next from the sim manager
3.) user clicks back, he will be shown the sim manager screen again
4.) user clicks back again, he will be shown language screen

This means the user will not be shown the SIM pin unlock again when going back. Note, this was the original flow that I had in place, but the module owner thought it was a bug (https://bugzilla.mozilla.org/show_bug.cgi?id=926347#c32). Just to make sure, once the user clicks back to go to the language screen again, and then clicks forward, should we show the SIM pin screens again before the SIM Manager? My thinking is that we should.

Comment 7

[Carrie Wang [New account: [e-mail]]]

Hi Michael,

What I was thinking about is that when users tap "back", the PIN entry page will not pop up but when they reach the language selection page again and then tap "Next", the SIM PIN page will then pop up. My understanding is that PIN entry is not a part of FTE, it's like a systematic thing. If the user want to go further and do some SIM-related settings, they shall unlock the SIM first, but if they want to go back to the language setting which is not restricted to the SIM, it's unnecessary to unlock the SIM. 

Hence, for your question, yes, we shall display the SIM pin screens again before the SIM Manager when they click forward on the language page.

Thanks!  :-)

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Github PR

Hi Francisco, would you mind taking a look at this? I know we did something different for bug 973661, but see comment 7 for the correct behavior of showing SIM unlock screens going forward and back. I tested this on dual and single sim devices.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8386407 [details]
Github PR

Nice work Mike!

Simple and clean solution, code looks great, when trying on the phone works perfect, for both single sim scenario and ds.

Thanks again!
F.

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/2bdc6a39b412d52305f7c172d831ad1b6e20fdf5

Comment 11

[Loli (:lolimartinezcr)]

Tested and working:
DSDS devices
Platform version: 30.0a1
Build ID:20140306094915
GIT commit: fcc877f2