965774 - [DSDS][FTE] Not exist 3 retries for each sim

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Loli (:lolimartinezcr)]

Tested (01/30/2014) 

Pre-requisites:
DSDS device.
Two sims cards with PIN inserted.

Steps:
In FTE
1. Insert two twices incorrect PIN in SIM1 card.
2. Third retry insert correctly PIN in SIM1 card.

Actual result:
In "Enter PIN code" in SIM2 card I can read "Last try"

Expected result:
In "Enter PIN code" in SIM2 card I can't read "Last try" because this SIM2 card has 3 retries.

Comment 1

[Loli (:lolimartinezcr)]

Tested (01/30/2014)
master
Build identifier: 20140130101312
Platform version: 29.0a1
Git commit: f856ac26

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Github PR

Hi Francisco, got another FTE review for you. I took this opportunity to add some unit tests for the dsds flows, since we needed it. Let me know your thoughts.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8386552 [details] [review]
Github PR

Thanks Mike!

Great job, and happy to see way too much lines of test than proper fix.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/4b7fd96c4debde75062e1f8be0f00a95bec96709

Comment 5

[Loli (:lolimartinezcr)]

Tested and working
Gecko ce6783c
Gaia 7306709