965828 - Change API library

Status: RESOLVED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

As bug 845593 comment 4 mentions, we need to change our API library in order to minimize the impact of keeping Django up to date. In this bug let's ...

* identify the library and version we wish to use
* make a branch for that work and work on it
* discuss how to integrate/launch
* build any blocking bugs (docs changes? api versioning? cleaning up endpoints?) required

Comment 1

[Giorgos Logiotatidis [:giorgos]]

My plan is to:
 1. Upgrade tastypie to a django 1.5 compatible version
 2. Upgrade to django >= 1.5 (bug 845593)
 3. Move on with this bug, evaluating different libraries and the overall API future.

--

For (1) as mentioned in bug 845593 comment 4 a few changes are needed. I've resolved some of them but some seem more complex. All the unresolved issues are linked to the 'city' and 'country' resources.

Those two endpoints, along with Group, Skill and Language endpoints were added before the 2013 Summit to support the summit app. These are undocumented and because of that I highly doubt if anyone is using them atm. 

I suggest that we drop those endpoints and thus unblock (1) and (2). Then we plan the API future and we decide if we properly support those endpoints or not.

What do you think?

Comment 2

[Justin Crawford [:hoosteeno] [:jcrawford]]

Giorgos, let's verify the usage of those endpoints by monitoring them for a week (using graphite?) and then move forward with your plan above.

Comment 3

[Giorgos Logiotatidis [:giorgos]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #1)
> Those two endpoints, along with Group, Skill and Language endpoints were
> added before the 2013 Summit to support the summit app. These are
> undocumented and because of that I highly doubt if anyone is using them atm. 

I was wrong about those being undocumented. There is documentation in the official docs. In any case we'll monitor them before acting.

Comment 4

[Justin Crawford [:hoosteeno] [:jcrawford]]

In meeting, Giorgos reported that...

UserResource being used daily
GroupResource was used once (possibly by the FirefoxOS Tablet program)
City, Country, Skill were never used

Let's get rid of the endpoints that were never used and plan to re-implement them after the bigger API authorization refactor is done (or as part of it).

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/a00ea48308ca624a98e7c71bb46e7362eeeaa3fe
[bug 965828] Tastypie upgrade.

- Upgrade tastypie to 0.9.16
- Remove Country and City resources.

Comment 6

[Giorgos Logiotatidis [:giorgos]]

De-assigning myself since I'm not working on mozillians now.