966103 - Add a "Sync now" button to the main FxA status screen

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Richard Newman [:rnewman]]

We already have this in the debug view, but it would be a nice addition.

Comment 1

[Nick Alexander :nalexander [he/him]]

ibarlow: could we get some mocks for how you'd like this to look?  I am imaging a status message and a button in the status activity; when you Sync, we replace the button with a spinner, etc; but this is your domain.  I'd very much like to land this during this cycle.

Comment 2

[Nick Alexander :nalexander [he/him]]

vivek, are you interested in this?  You did great work on the "Remove Account" menu item in the same activity.

This one would be a little different: this would have a "Sync" spinner icon and a "Sync now" button and a last synced time display.  Sort of like:

+----------+------------------------+
| spinning | Sync now               |
|   icon   | last synced time       |
+----------+------------------------+

1) Sync now starts Sync
2) start Sync spins the icon, grays out Sync now and last synced time
3) Sync stopping stops the icon, enables Sync button, updates last synced time

There's a spinning icon in Fennec that you can, for now, just copy over: it's called tabs_synced_*.xml and an icon.

Look at http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tabs/RemoteTabsContainerPanel.java for how to trigger and listen to Sync status results.

To extract the last Synced time, that will come from SharedPreferences.  We might want to land some code to make this simpler.

Comment 3

[Vivek Balakrishnan[:vivek]]

yes. I'm interested in working on this.

Comment 4

[Vivek Balakrishnan[:vivek]]

Attachment: Pull request created in android-sync project

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8504357 [details] [review]
Pull request created in android-sync project

Hey, sorry for the delay, I've been at some job training.  I'm traveling until early next week; I should get to this on Tuesday next.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8504357 [details] [review]
Pull request created in android-sync project

Comments on the PR.  This is looking really good.  I have questions and nits, and then I'll want to test myself locally, but it feels close.  Great work, vivek!

Comment 7

[Vivek Balakrishnan[:vivek]]

Attachment: Sync now pull request updated

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8518976 [details] [review]
Sync now pull request updated

This is looking great.  I've requested some small changes and that we split a few things off into separate tickets, but this is almost ready.

Thanks for your work and patience, and for really digging in to the android-sync code base.

Comment 9

[Vivek Balakrishnan[:vivek]]

Attachment: pull request updated

Comment 10

[John Gruen [:jgruen]]

Nick or Richard, could one of you guys screenshot the results of this PR so I can check the UI?

Comment 11

[Richard Newman [:rnewman]]

Nick, could you take care of this? I'm swamped.

Comment 12

[Nick Alexander :nalexander [he/him]]

Attachment: Sync.Now.Button.png

Comment 13

[Nick Alexander :nalexander [he/him]]

Attachment: Syncing.Button.png

Comment 14

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8520286 [details] [review]
pull request updated

Hi vivek, this is looking great!  I've cleaned up the commits and made some cosmetic changes at https://github.com/mozilla-services/android-sync/pull/505.  I've also fixed a significant issue: the timestamp you're showing is not the last synced timestamp, it's a different thing.  I have asked rnewman for a quick review on this.

I should land this tomorrow or Friday.

Thanks for all your work here; see you in the follow-ups...

Comment 15

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/acf1606913a8

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/acf1606913a8

Comment 17

[Francesco Lodolo [:flod]]

Nitpicking: for consistency "..." should always be "…" in all Mozilla products (single Unicode characters)

Comment 18

[Nick Alexander :nalexander [he/him]]

(In reply to Francesco Lodolo [:flod] from comment #17)
> Nitpicking: for consistency "..." should always be "…" in all Mozilla
> products (single Unicode characters)

flod: thanks for this.  Right when I landed, I wondered, but had already pulled the trigger.  I'll follow-up.

Comment 19

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/9d9d03721486

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d9d03721486