966113 - Update xperf whitelist with revised ICU version

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

We need to fix this because the ICU version number changed.

I'll file another bug to fix the dependentlibs.list issue.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Fix

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Fix r2

jwalden pointed out that we need to keep the old names in place until the builds have all transitioned to the new ones.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Filed bug 966121 for the dependentlibs.list issue.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8368344 [details] [diff] [review]
Fix r2

Review of attachment 8368344 [details] [diff] [review]:
-----------------------------------------------------------------

::: talos/xtalos/xperf_whitelist.json
@@ +45,5 @@
>   "{firefox}\\icuuc50.dll": {"mincount": 30, "maxcount": 30, "minbytes": 1966080, "maxbytes": 1966080},
>   "{firefox}\\icudt50.dll": {"mincount": 276, "maxcount": 276, "minbytes": 18087936, "maxbytes": 18087936},
> + "{firefox}\\icuin52.dll": {"mincount": 38, "maxcount": 40, "minbytes": 2490368, "maxbytes": 2621440},
> + "{firefox}\\icuuc52.dll": {"mincount": 30, "maxcount": 30, "minbytes": 1966080, "maxbytes": 1966080},
> + "{firefox}\\icudt52.dll": {"mincount": 276, "maxcount": 324, "minbytes": 18087936, "maxbytes": 21233664},

should we remove icu*50.dll entries?

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Fix

Actually we *can* remove the old entries as long as we land the updated talos.json to inbound with jwalden's push.

Carrying forward r+ as per discussion with jmaher on IRC.

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/build/talos/rev/087bbbe3bc3d

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

talos.json update in bug 966347