966218 - Right click options are offset in the RTL locales

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Theme, defect, P1)

Description

[Cornel Ionce [:noni] [Hubs QA]]

Attachment: right_click_options.png

Reproducing on latest Nightly and Aurora builds.

STR:
1. Open Metro Firefox
2. Right click a hiperlink/image or select some text and right click.

Expected results:
The options are correctly aligned to the right side and properly translated.

Actual results:
The options are offset and they are not localized.

Comment 1

[Cornel Ionce [:noni] [Hubs QA]]

The options are offset in the Arabic build to. Seems to be affecting the RTL locales.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Fix padding of popup menu items for rtl

Doh, here was me digging through the dom inspector and logging every silly thing out and suddenly I spot the padding-right culprit. Coulda grep'ed it

Comment 3

[Sam Foster [:sfoster] (he/him)]

https://hg.mozilla.org/integration/fx-team/rev/867cc82f5fa7

Comment 4

[Sam Foster [:sfoster] (he/him)]

huh that merged funny and yanked out a couple of newlines. I saw this before I pushed but thought my editor had trimmed some dead space characters. Oh well next time someone is in there maybe you could fix this up - I don't want to push again just for that.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/867cc82f5fa7

Comment 6

[Marco Mucci [:MarcoM]]

For testing and verification.  Reopen if any defects found.

Comment 7

[Kamil Jozwiak [:kjozwiak]]

Went through the verification process using the locale builds from the following location:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/

'ar' => Arabic (Padding has been correctly fixed and the menu's are localized)
- firefox-30.0a1.ar.win32.installer.exe

'fa' => Persian (Padding has been correctly fixed and the menu's are NOT localized)
- firefox-30.0a1.fa.win32.installer.exe

'he' => Hebrew (Padding has been correctly fixed and the menu's are NOT localized)
- firefox-30.0a1.he.win32.installer.exe

Sam, should a new issue be created regarding the text under the context menu's not being localized with both Persian/Hebrew locales? (a lot of the text is not localized)

Comment 8

[Kamil Jozwiak [:kjozwiak]]

I'm going to close this issue has the original problem has been fixed, a new issue will be created for the two locales not being translated and still appearing in English. However, the offset has been fixed in the context menu's.