Right click options are offset in the RTL locales

VERIFIED FIXED in Firefox 30

Status

defect
P1
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: cornel_ionce, Assigned: sfoster)

Tracking

Trunk
Firefox 30
All
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=1 s=it-30c-29a-28b.3 r=ff30)

Attachments

(2 attachments)

Reproducing on latest Nightly and Aurora builds.

STR:
1. Open Metro Firefox
2. Right click a hiperlink/image or select some text and right click.

Expected results:
The options are correctly aligned to the right side and properly translated.

Actual results:
The options are offset and they are not localized.
Whiteboard: [triage]
The options are offset in the Arabic build to. Seems to be affecting the RTL locales.
Summary: Right click options are offset and not localized in the "he" locale → Right click options are offset in the RTL locales
Hardware: x86 → All

Updated

5 years ago
Blocks: 851165

Updated

5 years ago
Component: Metro Operations → Theme
Product: Tracking → Firefox for Metro
Version: --- → Trunk
Blocks: metrobacklog
Whiteboard: [triage] → [triage] [defect] p=0
Priority: -- → P1
Whiteboard: [triage] [defect] p=0 → p=0
(Assignee)

Updated

5 years ago
Assignee: nobody → sfoster
Whiteboard: p=0 → p=1 s=it-30c-29a-28b.3
Status: NEW → ASSIGNED
QA Contact: kamiljoz
Whiteboard: p=1 s=it-30c-29a-28b.3 → p=1 s=it-30c-29a-28b.3 r=ff30
(Assignee)

Comment 2

5 years ago
Doh, here was me digging through the dom inspector and logging every silly thing out and suddenly I spot the padding-right culprit. Coulda grep'ed it
Attachment #8386993 - Flags: review?(mbrubeck)
Attachment #8386993 - Flags: review?(mbrubeck) → review+
(Assignee)

Comment 4

5 years ago
huh that merged funny and yanked out a couple of newlines. I saw this before I pushed but thought my editor had trimmed some dead space characters. Oh well next time someone is in there maybe you could fix this up - I don't want to push again just for that.
https://hg.mozilla.org/mozilla-central/rev/867cc82f5fa7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
For testing and verification.  Reopen if any defects found.
Flags: needinfo?(kamiljoz)
Went through the verification process using the locale builds from the following location:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/

'ar' => Arabic (Padding has been correctly fixed and the menu's are localized)
- firefox-30.0a1.ar.win32.installer.exe

'fa' => Persian (Padding has been correctly fixed and the menu's are NOT localized)
- firefox-30.0a1.fa.win32.installer.exe

'he' => Hebrew (Padding has been correctly fixed and the menu's are NOT localized)
- firefox-30.0a1.he.win32.installer.exe

Sam, should a new issue be created regarding the text under the context menu's not being localized with both Persian/Hebrew locales? (a lot of the text is not localized)
Flags: needinfo?(sfoster)
I'm going to close this issue has the original problem has been fixed, a new issue will be created for the two locales not being translated and still appearing in English. However, the offset has been fixed in the context menu's.
Status: RESOLVED → VERIFIED
Flags: needinfo?(sfoster)
Flags: needinfo?(kamiljoz)
You need to log in before you can comment on or make changes to this bug.