966245 - Make session start rulers visible in Thunderbird chat logs

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[aleth [:aleth]]

The rulers between sessions in chat logs are currently hidden by the TB message style CSS.

Comment 1

[aleth [:aleth]]

Attachment: 966245.patch

Adds simple CSS for the session start ruler.

This removes the code dealing with hr's in Footer.html as those are currently always hidden anyway (even when the system messages are expanded). Instead the hr's are simply not inserted in the first place.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8368538 [details] [diff] [review]
966245.patch

Review of attachment 8368538 [details] [diff] [review]:
-----------------------------------------------------------------

Two comments that may not necessarily need code changes. The rest looks good.

::: mail/components/im/messages/Footer.html
@@ +43,4 @@
>    var nbEvents = P_list.length;
>  
>    if (target.className == "button hide") {
> +    for (var i=1; i < (nbEvents-2); i++)

I would like you to check what this 2 means, to confirm that it doesn't need to be changed to 1 after removing the <hr>s.

@@ +49,5 @@
>  
>      target.className = "button show";
>    }
>    else {
> +    for (var i=1; i < (nbEvents-2); i++)

Same here.

Comment 3

[aleth [:aleth]]

(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> >    if (target.className == "button hide") {
> > +    for (var i=1; i < (nbEvents-2); i++)
> 
> I would like you to check what this 2 means, to confirm that it doesn't need
> to be changed to 1 after removing the <hr>s.

The -2 refers to the two status messages that remain displayed after a block is collapsed.

Comment 4

[aleth [:aleth]]

Comment on attachment 8368538 [details] [diff] [review]
966245.patch

The changes to Footer.html would leave the code in an ugly state, so I think I'll look at this again.

Comment 5

[aleth [:aleth]]

Attachment: 966245.patch 2

This ports the current code from Bubbles, using a MutationObserver and CSS to fold the status messages.

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8374105 [details] [diff] [review]
966245.patch 2

Review of attachment 8374105 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup! :)

Assuming you've tested it, r=me.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/f97b050c27c3