Closed
Bug 96642
Opened 23 years ago
Closed 22 years ago
Mail Compose 'To' field is not resizable
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.4alpha
People
(Reporter: rsmyth, Assigned: neil)
References
Details
(Keywords: l12y, Whiteboard: [adt3][ish])
Attachments
(5 files)
44.51 KB,
image/jpeg
|
Details | |
4.63 KB,
patch
|
Details | Diff | Splinter Review | |
12.47 KB,
image/jpeg
|
Details | |
3.20 KB,
patch
|
jag+mozilla
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
1.03 KB,
patch
|
Details | Diff | Splinter Review |
In the Mail Compose window, when 'Newsgroup' is selected in the addressee field
the text becomes truncated in localised builds - see attached image.
This field should be resizable, localised text normally expands by up to 20-30%.
This is related to bugscape bug no. 8896
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Comment 2•23 years ago
|
||
Adding l12y keyword
Changed the component and reassigned to mscott. Please reassign to appropriate
person. Thanks.
Status: UNCONFIRMED → NEW
Component: Localization → Mail Window Front End
Ever confirmed: true
Keywords: l12y
Comment 5•23 years ago
|
||
ji - is this one still valid?
I don't see this problem on a Ja build, but it could be because the Ja string is
shorter. Rose, do you still have this problem on a German or French build?
Reporter | ||
Comment 7•23 years ago
|
||
Yes, the problem is still there for German and French. The field needs to be
resizable to accomodate text expansion due to localisation.
Updated•23 years ago
|
mscott, please reconsider the bug again. This bug is really ugly.
->nsbeta1.
Comment 10•23 years ago
|
||
renominating; I don't know why it was marked nsbeta1-. It's critical for l10n
Comment 11•23 years ago
|
||
Discussed in 2/26 bug meeting with Mktg Engineering and PjM. Decision was to
nsbeta1 minus, reassign to varada, and move to Future.
Comment 12•23 years ago
|
||
Working on it now.
The "listcol-addressingWidget" width needs to move from "messengercompose.css"
to a dtd file.
Comment 13•23 years ago
|
||
Comment 14•23 years ago
|
||
Please review the above patch.
Comment 15•23 years ago
|
||
This problem described here also happen in US build. With 2002-02-28 build, texts
got cut off after the 5th characters in the "Reply to", "Follow up", and
"Newsgroup" fields. How do users know what the labels really are? Isn't this a
usability issue?
Comment 16•23 years ago
|
||
I do not see the problem with the US builds using Mar-01-2002 build. The patch
is good but I dont know about the guidelines for moving styles from CSS to DTD
files. I think you should clarify with someone like andreww@netscape.com or
hewitt@netscape.com
Comment 17•23 years ago
|
||
I think this is a no-no for several reasons:
1) there should never be in-lined style references in xul. Even if
somethign is hard-coded via a content stylesheet - it should reside in a
.css file, not in the .xul file
2) style information should not reside in a .dtd file. This sets a dangerous
precendent for there being too many cross - dependancies on a dtd to
have some skin appear properly.
Couldnt this be solved fairly easily by setting a max-width and a min-width
on that field in the .css file?
for instance :
#listcol-addressingWidget {
min-width: 9em;
max-width: 13em;
border-right: 1px solid #CACAFF;
Also it looks like the text of the addressing widget is not overflowing
properly like foobar... not having text float off into another widget.
So, no - this is not an acceptible solution. I'd be happy to help you find a
way to do this that doesnt cross the DTD/XUL/CSS boundaries.
Comment 18•23 years ago
|
||
I agree with the earlier comment by andreww, we can't be moving style
information into the locale.
Comment 19•23 years ago
|
||
Just did test by setting the min-width/max-width in css suggested by andreww, doesn't work, the width won't change with long string.
Comment 20•23 years ago
|
||
The current workaround for this bug:
In DE build, increase the width in addressingWidget.css, in both modern.jar and
classic.jar:
#listcol-addressingWidget {
width: 9em;
border-right: 1px solid #C4CADC;
}
Comment 21•23 years ago
|
||
removing "-" to nsbeta1 for buffy
Comment 22•22 years ago
|
||
is this a problem for japanese?
Comment 23•22 years ago
|
||
Since Ja translation for "To" is much shorter, this won't be a problem for Ja
version of the product.
Comment 24•22 years ago
|
||
but we are going to have the problem for DE, this bug was originally reported by
DE team, see comment #1...
Comment 25•22 years ago
|
||
Even with English build, the "Follow-up", "Newsgroup", and "Reply-to" labels are
trimmed.
Comment 26•22 years ago
|
||
> is this a problem for japanese?
Yes, the "Newsgroup" is truncated.
Comment 27•22 years ago
|
||
Int'l triage team recommends nsbeta1+
Comment 30•22 years ago
|
||
Mail triage team: nsbeta1+/adt3
Assignee | ||
Comment 31•22 years ago
|
||
{ width: auto } makes the column size to the longest visible entry,
not to the size of the drop-down...
Assignee | ||
Comment 32•22 years ago
|
||
Assignee | ||
Comment 33•22 years ago
|
||
Comment on attachment 113906 [details] [diff] [review]
Proposed patch
I checked the other users of listcol to make sure that they don't mind removing
the width leaving the min-width as per treecol.
I'm assuming that there are no other users of .menulist-compact :-)
You may want to change the width: 9em; into min-width: 9em; rather than
deleting it.
Attachment #113906 -
Flags: superreview?(sspitzer)
Attachment #113906 -
Flags: review?(yxia)
Comment 34•22 years ago
|
||
Seems I am not allowed to click "Edit" in the action column, you better ask
someone else. Myself think it's good to "makes the column size to the longest
visible entry".
Comment 35•22 years ago
|
||
here's an easy way to reproduce this in english builds.
use the hidden "mail.compose.other.header" pref.
see http://www.mozilla.org/mailnews/arch/hiddenprefs.html
re-assign to neil, since he has a fix.
Assignee: sspitzer → neil
Comment 36•22 years ago
|
||
Comment on attachment 113906 [details] [diff] [review]
Proposed patch
since this is xpfe, I think jag is the right person to review.
I'll give the sr once he does the review.
Attachment #113906 -
Flags: review?(yxia) → review?(jaggernaut)
Comment 37•22 years ago
|
||
Comment on attachment 113906 [details] [diff] [review]
Proposed patch
r=jag
Attachment #113906 -
Flags: review?(jaggernaut) → review+
Comment 38•22 years ago
|
||
Comment on attachment 113906 [details] [diff] [review]
Proposed patch
sr=sspitzer
this can wait for 1.4 alpha.
thanks neil!
Attachment #113906 -
Flags: superreview?(sspitzer) → superreview+
Comment 39•22 years ago
|
||
accepting, and assigning to 1.4 alpha, on neil's behalf.
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla1.4alpha
Assignee | ||
Comment 40•22 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 41•22 years ago
|
||
the label fields will change dynamically now.
for example, compose a message and have to,cc,cc,cc,cc,cc,newsgroup
the widths of all the addresses will change as the newsgroup entry is visible or
not.
this is probably already logged, but I haven't queried for it.
Comment 42•22 years ago
|
||
supplimental patch (suggested by neil) to help make the problem I pointed out
not as bad on US-ASCII builds.
Comment 43•22 years ago
|
||
I've checked in the supplimental patch, to try to make things better for en-US
builds, but still fix the problem for localized builds.
thanks for neil for the suggestion.
Comment 44•22 years ago
|
||
this might have caused a problem with the mail search/ab search/filter/view dialog.
from shuehan:
"in the search dialog, in the search term listbox, when you select different
things in the menulists, they change widths."
I see this too, and think it might have been this change.
I think the fix will be to add min-widths, like neil suggested we do for compose.
Comment 45•22 years ago
|
||
the regression I just mentioned is now bug #195313, assigned to shliang
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•