966557 - make nsIX509CertDB.ConstructX509Cert

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

+++ This bug was initially created as a clone of Bug #928536 +++

See https://bugzilla.mozilla.org/show_bug.cgi?id=928536#c47.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

No "FromRawDER" please.

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Add nsIX509CertDB.ConstructX509FromRawDER (

Comment 3

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Add nsIX509CertDB.ConstructX509FromRawDER (

Comment 4

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8368992 [details] [diff] [review]
Add nsIX509CertDB.ConstructX509FromRawDER (

./mach xpcshell and ./mach gtest in security/manager/ssl work.

Comment 5

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8368992 [details] [diff] [review]
Add nsIX509CertDB.ConstructX509FromRawDER (

Review of attachment 8368992 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/ssl/src/nsNSSCertificateDB.cpp
@@ +1427,5 @@
> +}
> +
> +/* nsIX509Cert constructX509 (in string certDER, unsigned long len); */
> +NS_IMETHODIMP
> +nsNSSCertificateDB::ConstructX509(const char *certDER,

const char* certDER,

@@ +1429,5 @@
> +/* nsIX509Cert constructX509 (in string certDER, unsigned long len); */
> +NS_IMETHODIMP
> +nsNSSCertificateDB::ConstructX509(const char *certDER,
> +                                  uint32_t lengthDER,
> +                                  nsIX509Cert **_retval)

nsIX509Cert** _retval)

@@ +1435,5 @@
> +  nsNSSShutDownPreventionLock locker;
> +  if (isAlreadyShutDown()) {
> +    return NS_ERROR_NOT_AVAILABLE;
> +  }
> +  NS_ENSURE_ARG_POINTER(_retval);

https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#Use_the_nice_macros

Comment 6

[[:mmc] Monica Chew (no longer reading bugmail)]

(In reply to Brian Smith (:briansmith, :bsmith; NEEDINFO? for response) from comment #5)
> https://developer.mozilla.org/en-US/docs/Developer_Guide/
> Coding_Style#Use_the_nice_macros

Time to switch to portrait mode on my laptop. Fixed and checking in.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/af7bcffbbac9

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/af7bcffbbac9