Closed Bug 966893 Opened 10 years ago Closed 10 years ago

Icon & text in rocketbar search reuslts is too small for apps, which causes marketplace's app name to be cut off

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jsmith, Assigned: kgrandon)

References

Details

(Whiteboard: [mwcdemo2014])

Attachments

(3 files, 1 obsolete file)

Github pull request
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
before-patch.png
52.88 KB, image/png
Details
after-patch.png
51.52 KB, image/png
epang
: review+
Details
Attached image RocketbarSearchResults.png (obsolete) — 
Build:

* Gecko: 83a3ef9b2144
* Gaia: 3b2fe2f86164f95db699b6ea2661925b21ecb994
* Build ID: 20140202160200
* Version: 1.4

STR

1. Open rocketbar
2. Type a letter, then delete it
3. Click away within rocketbar search results to see all apps currently in the search results

Expected

Marketplace's app name should be fully visible.

Actual

Marketplace's app name is cut off.
This needs VD input.
Flags: needinfo?(firefoxos-ux-bugzilla)
Eric is at the work week this week, so I'm redirecting this to him.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(epang)
Whiteboard: [mwcdemo2014]
Blocks: rocketbar-search-mvp
Hi, thanks Jason!  The font size and style in the rocket bar should be the same as on the homescreen.  If we update it to match the homescreen "Marketplace" should no longer be cut off.
Flags: needinfo?(epang)
Attached file Github pull request — 

    
  
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED

    
    

    
  

      
      
      
      

        Attached image
          
        before-patch.png
        — 
      

    


  

        Attachment #8369322 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached image
          
        after-patch.png
        — 
      

    


  
Hey Eric - I know we're still exploring more visual designs, but I was wondering if you could sign of on the sizing of this new font. Thanks!

        Attachment #8370584 -
        Flags: review?(epang)

    
    

    
  
Comment on attachment 8370584 [details]
after-patch.png

Sizing looks good. Thanks for the fix Kevin!

        Attachment #8370584 -
        Flags: review?(epang) → review+

    
    

    
  
Comment on attachment 8370580 [details] [review]
Github pull request

r=me and epang for the visual review then. Thanks for taking a look.

        Attachment #8370580 -
        Flags: review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/gaia/commit/eaec1c373c686833fba37a53af86a0fc39e7ac66
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: