Icon & text in rocketbar search reuslts is too small for apps, which causes marketplace's app name to be cut off

RESOLVED FIXED

Status

Firefox OS
Gaia::Search
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jsmith, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mwcdemo2014])

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 8369322 [details]
RocketbarSearchResults.png

Build:

* Gecko: 83a3ef9b2144
* Gaia: 3b2fe2f86164f95db699b6ea2661925b21ecb994
* Build ID: 20140202160200
* Version: 1.4

STR

1. Open rocketbar
2. Type a letter, then delete it
3. Click away within rocketbar search results to see all apps currently in the search results

Expected

Marketplace's app name should be fully visible.

Actual

Marketplace's app name is cut off.
(Reporter)

Comment 1

4 years ago
This needs VD input.
Flags: needinfo?(firefoxos-ux-bugzilla)
(Reporter)

Comment 2

4 years ago
Eric is at the work week this week, so I'm redirecting this to him.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(epang)
(Reporter)

Updated

4 years ago
Whiteboard: [mwcdemo2014]
(Reporter)

Updated

4 years ago
Blocks: 946452
Hi, thanks Jason!  The font size and style in the rocket bar should be the same as on the homescreen.  If we update it to match the homescreen "Marketplace" should no longer be cut off.
Flags: needinfo?(epang)
(Assignee)

Comment 4

4 years ago
Created attachment 8370580 [details] [review]
Github pull request
(Assignee)

Updated

4 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Comment 5

4 years ago
Created attachment 8370583 [details]
before-patch.png
Attachment #8369322 - Attachment is obsolete: true
(Assignee)

Comment 6

4 years ago
Created attachment 8370584 [details]
after-patch.png

Hey Eric - I know we're still exploring more visual designs, but I was wondering if you could sign of on the sizing of this new font. Thanks!
Attachment #8370584 - Flags: review?(epang)
Comment on attachment 8370584 [details]
after-patch.png

Sizing looks good. Thanks for the fix Kevin!
Attachment #8370584 - Flags: review?(epang) → review+
(Assignee)

Comment 8

4 years ago
Comment on attachment 8370580 [details] [review]
Github pull request

r=me and epang for the visual review then. Thanks for taking a look.
Attachment #8370580 - Flags: review+
(Assignee)

Comment 9

4 years ago
Landed: https://github.com/mozilla-b2g/gaia/commit/eaec1c373c686833fba37a53af86a0fc39e7ac66
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.