966899 - Rocketbar is not enabled after OTA update

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kevin Grandon :kgrandon]

Rocketbar is not being enabled when a user does an OTA update. We need to fix this as we likely want users to be able to use rocketbar when they update.

Seems like we need to update the settings DB version.

Comment 1

[Jason Smith [:jsmith]]

Saw this as well. Workaround is do a factory reset on the phone after doing a fullflash.

Comment 2

[Kevin Grandon :kgrandon]

I'll take this and try updating custom-settings as suggested.

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8369365 [details] [review]
Github pull request

Still testing this to ensure this will work as a user.

Comment 5

[:gerard-majax]

This does not work, however bumping settingsdb version does the trick.

Comment 6

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8369365 [details] [review]
Github pull request

Hey Guys - do you guys by chance to review this patch? Thanks!

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Kevin,

After sitting on this for the night I found the database upgrade code will indeed update the default value in the profile.

http://dxr.mozilla.org/mozilla-central/source/dom/settings/SettingsDB.jsm#80

So a IndexedDB version upgrade do more than schema upgrade. This is not what I suspected in IRC.

I would be better if Gregor could document the behavior somewhere in MDN/Wiki.


Tim

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8369365 [details] [review]
Github pull request

gwagner, I think we have assigned correct values to rocketbar.enabled and rocketbar.searchAppURL in settings.js, why should we assign it again in common-settings.json?

[1] https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L108

Comment 10

[Gregor Wagner [:gwagner]]

(In reply to Yuren [:yurenju][:小朱] from comment #9)
> Comment on attachment 8369365 [details] [review]
> Github pull request
> 
> gwagner, I think we have assigned correct values to rocketbar.enabled and
> rocketbar.searchAppURL in settings.js, why should we assign it again in
> common-settings.json?
> 
> [1] https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L108

I think you are right. Creating the settings file changed too many times on me :) So we only have to bump the DB version and read the new settings into the DB.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8369365 [details] [review]
Github pull request

okay, let's cancel the review flag.

Comment 12

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/0ef1b8459d86

Comment 13

[Jason Smith [:jsmith]]

http://hg.mozilla.org/mozilla-central/rev/0ef1b8459d86