Closed Bug 966899 Opened 6 years ago Closed 6 years ago

Rocketbar is not enabled after OTA update

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.4+, firefox28 wontfix, firefox29 wontfix, firefox30 fixed, b2g-v1.4 fixed)

RESOLVED FIXED
1.4 S1 (14feb)
blocking-b2g 1.4+
Tracking Status
firefox28 --- wontfix
firefox29 --- wontfix
firefox30 --- fixed
b2g-v1.4 --- fixed

People

(Reporter: kgrandon, Assigned: gwagner)

References

Details

(Keywords: dataloss, smoketest, Whiteboard: [mwcdemo2014][systemsfe][p=1])

Attachments

(2 files)

Rocketbar is not being enabled when a user does an OTA update. We need to fix this as we likely want users to be able to use rocketbar when they update.

Seems like we need to update the settings DB version.
Saw this as well. Workaround is do a factory reset on the phone after doing a fullflash.
Keywords: dataloss
Whiteboard: [mwcdemo2014]
I'll take this and try updating custom-settings as suggested.
Assignee: anygregor → kgrandon
Attached file Github pull request
Comment on attachment 8369365 [details] [review]
Github pull request

Still testing this to ensure this will work as a user.
Attachment #8369365 - Flags: review?(lissyx+mozillians)
This does not work, however bumping settingsdb version does the trick.
Attached patch patchSplinter Review
Comment on attachment 8369365 [details] [review]
Github pull request

Hey Guys - do you guys by chance to review this patch? Thanks!
Attachment #8369365 - Flags: review?(yurenju.mozilla)
Attachment #8369365 - Flags: review?(lissyx+mozillians)
Attachment #8369365 - Flags: review?(gduan.moz)
Keywords: smoketest
blocking-b2g: --- → 1.4?
Whiteboard: [mwcdemo2014] → [mwcdemo2014][systemsfe]
Kevin,

After sitting on this for the night I found the database upgrade code will indeed update the default value in the profile.

http://dxr.mozilla.org/mozilla-central/source/dom/settings/SettingsDB.jsm#80

So a IndexedDB version upgrade do more than schema upgrade. This is not what I suspected in IRC.

I would be better if Gregor could document the behavior somewhere in MDN/Wiki.


Tim
Comment on attachment 8369365 [details] [review]
Github pull request

gwagner, I think we have assigned correct values to rocketbar.enabled and rocketbar.searchAppURL in settings.js, why should we assign it again in common-settings.json?

[1] https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L108
Flags: needinfo?(anygregor)
Target Milestone: --- → 1.4 S1 (14feb)
(In reply to Yuren [:yurenju][:小朱] from comment #9)
> Comment on attachment 8369365 [details] [review]
> Github pull request
> 
> gwagner, I think we have assigned correct values to rocketbar.enabled and
> rocketbar.searchAppURL in settings.js, why should we assign it again in
> common-settings.json?
> 
> [1] https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L108

I think you are right. Creating the settings file changed too many times on me :) So we only have to bump the DB version and read the new settings into the DB.
Flags: needinfo?(anygregor)
Comment on attachment 8369365 [details] [review]
Github pull request

okay, let's cancel the review flag.
Attachment #8369365 - Flags: review?(yurenju.mozilla)
Attachment #8369365 - Flags: review?(gduan.moz)
Attachment #8369384 - Flags: review?(bent.mozilla)
Attachment #8369384 - Flags: review?(bent.mozilla) → review+
blocking-b2g: 1.4? → 1.4+
Whiteboard: [mwcdemo2014][systemsfe] → [mwcdemo2014][systemsfe][status:on inbound heading to land]
http://hg.mozilla.org/mozilla-central/rev/0ef1b8459d86
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Component: Gaia → General
Resolution: --- → FIXED
Whiteboard: [mwcdemo2014][systemsfe][status:on inbound heading to land] → [mwcdemo2014][systemsfe][status:on inbound heading to land][p=1]
Whiteboard: [mwcdemo2014][systemsfe][status:on inbound heading to land][p=1] → [mwcdemo2014][systemsfe][p=1]
You need to log in before you can comment on or make changes to this bug.