Closed Bug 966902 Opened 6 years ago Closed 6 years ago

Rocketbar - Returning to the search bar with a search term present removes the search term

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S1 (14feb)

People

(Reporter: jsmith, Assigned: kgrandon)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
benfrancis
: review+
Details | Review
Build:

* Gecko: 83a3ef9b2144
* Gaia: 3b2fe2f86164f95db699b6ea2661925b21ecb994
* Build ID: 20140202160200
* Version: 1.4

STR

1. Open rocketbar
2. Type s
3. Click away to have keyboard disappear
4. Click rocketbar search bar again

Expected

The term s is still present in rocketbar search bar.

Actual

The term s is deleted upon clicking the search bar again.
Attached file Github pull request
Ben - could you give this a quick review? This is mainly removing the clearing of input, as well as JSHint fixes. Thanks!
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attachment #8369979 - Flags: review?(bfrancis)
Comment on attachment 8369979 [details] [review]
Github pull request

Or maybe alive can look if you have a minute also.
Attachment #8369979 - Flags: review?(alive)
Target Milestone: --- → 1.4 S1 (14feb)
Comment on attachment 8369979 [details] [review]
Github pull request

Going to simplify this one and have ben do the review. Thanks!
Attachment #8369979 - Flags: review?(alive)
Attachment #8369979 - Flags: review?(bfrancis) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/1256ee2739d780f4bab85ed3950f56fb0ae70677
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.