Closed Bug 966907 Opened 6 years ago Closed 6 years ago

Light icon for search box in light theme

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(firefox29 verified, firefox30 verified)

VERIFIED FIXED
Firefox 30
Tracking Status
firefox29 --- verified
firefox30 --- verified

People

(Reporter: Optimizer, Assigned: bgrins)

References

Details

(Whiteboard: [bugday-20140212])

Attachments

(1 file, 1 obsolete file)

see the screenshot : https://pbs.twimg.com/media/BfdERUHCcAAdBq5.png:large

The search icon is not visible as it was meant for dark theme. We need to update this icon too.

(and uplift this)
Flags: needinfo?(bgrinstead)
Blocks: 966661
Attached patch theme-search-icons.patch (obsolete) — Splinter Review
Added light theme and 2x variants for the magnifying glass icon.  Added them to shared folder and removed the old one out of OS specific folders. Try push: https://tbpl.mozilla.org/?tree=Try&rev=e05a51c7b81d
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8369434 - Flags: review?(vporof)
Flags: needinfo?(bgrinstead)
Comment on attachment 8369434 [details] [diff] [review]
theme-search-icons.patch

Review of attachment 8369434 [details] [diff] [review]:
-----------------------------------------------------------------

<3
Attachment #8369434 - Flags: review?(vporof) → review+
Rebased patch
Attachment #8369434 - Attachment is obsolete: true
Attachment #8370006 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f817fcb93e52
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Blocks: 957117
No longer blocks: 957117
Depends on: 957117
Comment on attachment 8370006 [details] [diff] [review]
theme-search-icons.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 957117
User impact if declined: Search box magnifier icon will be low contrast on the light DevTools theme
Testing completed (on m-c, etc.): On m-c since 02-04
Risk to taking this patch (and alternatives if risky): Low risk styling change for DevTools
String or IDL/UUID changes made by this patch:
Attachment #8370006 - Flags: approval-mozilla-aurora?
Attachment #8370006 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
successfully verified the fixed on latest firefox 29 and 30.
Whiteboard: [bugday-20140212]
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.