966907 - Light icon for search box in light theme

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Girish Sharma [:Optimizer]]

see the screenshot : https://pbs.twimg.com/media/BfdERUHCcAAdBq5.png:large

The search icon is not visible as it was meant for dark theme. We need to update this icon too.

(and uplift this)

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: theme-search-icons.patch

Added light theme and 2x variants for the magnifying glass icon.  Added them to shared folder and removed the old one out of OS specific folders. Try push: https://tbpl.mozilla.org/?tree=Try&rev=e05a51c7b81d

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8369434 [details] [diff] [review]
theme-search-icons.patch

Review of attachment 8369434 [details] [diff] [review]:
-----------------------------------------------------------------

<3

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: theme-search-icons.patch

Rebased patch

Comment 4

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/f817fcb93e52
https://tbpl.mozilla.org/?tree=Fx-Team&rev=f817fcb93e52

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f817fcb93e52

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8370006 [details] [diff] [review]
theme-search-icons.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 957117
User impact if declined: Search box magnifier icon will be low contrast on the light DevTools theme
Testing completed (on m-c, etc.): On m-c since 02-04
Risk to taking this patch (and alternatives if risky): Low risk styling change for DevTools
String or IDL/UUID changes made by this patch:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/794d8c507160

Comment 8

[Ashickur Rahman]

successfully verified the fixed on latest firefox 29 and 30.