Closed
Bug 967101
Opened 10 years ago
Closed 10 years ago
Add leave-open keyword
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: snorp, Assigned: dkl)
References
Details
Right now we use "[leave-open]" in the whiteboard to indicate that the bug should be left open once the relevant patches have been merged. I can never remember the right string for this, and would prefer to have a keyword which is autocompleted.
Assignee | ||
Comment 1•10 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #0) > Right now we use "[leave-open]" in the whiteboard to indicate that the bug > should be left open once the relevant patches have been merged. I can never > remember the right string for this, and would prefer to have a keyword which > is autocompleted. Thanks. We will need a brief description of the keyword to proceed. https://wiki.mozilla.org/BMO/Requesting_Changes#Keywords dkl
Flags: needinfo?(snorp)
Reporter | ||
Comment 2•10 years ago
|
||
Keyword: leave-open Description: Instructs merge tools to leave the bug open when the patches are merged to mozilla-central Right now we do this with a whiteboard tag "[leave-open]" which has does not have autocompletion. I can never remember the right format.
Flags: needinfo?(snorp)
Comment 3•10 years ago
|
||
This is what mcMerge currently looks for on the whiteboard: https://mxr.mozilla.org/webtools-central/source/tbpl/mcmerge/js/Config.js#19
Comment 4•10 years ago
|
||
Also, TBPL will need to be patched to look for this before it can go live. Not sure who's volunteering to do that.
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #4) > Also, TBPL will need to be patched to look for this before it can go live. > Not sure who's volunteering to do that. I can add the keyword to BMO and close this ticket, and people can switch to using the keyword once TBPL has been updated. Sound OK? dkl
Flags: needinfo?(ryanvm)
Comment 6•10 years ago
|
||
If you add it, people will use it. How would they know not to? I don't want to see this added until there's a TBPL patch up for review.
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #6) > If you add it, people will use it. How would they know not to? I don't want > to see this added until there's a TBPL patch up for review. Fair point. Please ping when this is ready to proceed. dkl
Comment 8•10 years ago
|
||
You should be good to proceed, David :)
Assignee | ||
Comment 9•10 years ago
|
||
Keyword added. dkl
Assignee: nobody → dkl
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 10•10 years ago
|
||
The new keyword is indeed visible on describekeywords.cgi, show_bug.cgi and even enter_bug.cgi. => VERIFIED.
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
Updated•5 years ago
|
Component: Extensions: BMO → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•