967101 - Add leave-open keyword

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Right now we use "[leave-open]" in the whiteboard to indicate that the bug should be left open once the relevant patches have been merged. I can never remember the right string for this, and would prefer to have a keyword which is autocompleted.

Comment 1

[David Lawrence [:dkl]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #0)
> Right now we use "[leave-open]" in the whiteboard to indicate that the bug
> should be left open once the relevant patches have been merged. I can never
> remember the right string for this, and would prefer to have a keyword which
> is autocompleted.

Thanks. We will need a brief description of the keyword to proceed.

https://wiki.mozilla.org/BMO/Requesting_Changes#Keywords

dkl

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Keyword: leave-open
Description: Instructs merge tools to leave the bug open when the patches are merged to mozilla-central

Right now we do this with a whiteboard tag "[leave-open]" which has does not have autocompletion. I can never remember the right format.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This is what mcMerge currently looks for on the whiteboard:
https://mxr.mozilla.org/webtools-central/source/tbpl/mcmerge/js/Config.js#19

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Also, TBPL will need to be patched to look for this before it can go live. Not sure who's volunteering to do that.

Comment 5

[David Lawrence [:dkl]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #4)
> Also, TBPL will need to be patched to look for this before it can go live.
> Not sure who's volunteering to do that.

I can add the keyword to BMO and close this ticket, and people can switch to using the keyword once TBPL has been updated. Sound OK?

dkl

Comment 6

[Ryan VanderMeulen [:RyanVM]]

If you add it, people will use it. How would they know not to? I don't want to see this added until there's a TBPL patch up for review.

Comment 7

[David Lawrence [:dkl]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #6)
> If you add it, people will use it. How would they know not to? I don't want
> to see this added until there's a TBPL patch up for review.

Fair point. Please ping when this is ready to proceed.

dkl

Comment 8

[Ryan VanderMeulen [:RyanVM]]

You should be good to proceed, David :)

Comment 9

[David Lawrence [:dkl]]

Keyword added.

dkl

Comment 10

[Tony Mechelynck [:tonymec]]

The new keyword is indeed visible on describekeywords.cgi, show_bug.cgi and even enter_bug.cgi. => VERIFIED.